Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	neil.armstrong@linaro.org, olteanv@gmail.com
Subject: Re: [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
Date: Tue, 17 Nov 2026 09:16:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-218467@kernel.org> (raw)
In-Reply-To: <20261117-qcom-nord-ahb2phy-clk-v3-2-ce5ee1073208@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: phy: qcom,snps-eusb2-phy: duplicated Nord if-then
  conditionals
--

commit 13c4e9b2c7f49f0e94267a2da3fb8460b96d9170
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock

This commit drops the qcom,sm8550-snps-eusb2-phy fallback for
qcom,nord-snps-eusb2-phy and requires a second "bus" clock for the Nord
AHB2PHY bridge while keeping a single "ref" clock for other compatibles.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 931cd0e7d297e..40c0b8b42182d 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml

[ ... ]

> @@ -77,6 +82,24 @@ allOf:
>        required:
>          - resets
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,nord-snps-eusb2-phy
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 2
> +        clock-names:
> +          minItems: 2
> +    else:
> +      properties:
> +        clocks:
> +          maxItems: 1
> +        clock-names:
> +          maxItems: 1
> +
>  additionalProperties: false
>  
>  examples:

[Severity: Low]
This isn't a bug, but now that qcom,nord-snps-eusb2-phy no longer falls
back to qcom,sm8550-snps-eusb2-phy and differs in both clocks and required
resets, could it be split into a separate binding schema or at least have
both allOf conditionals for qcom,nord-snps-eusb2-phy combined by moving
required resets into this else branch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-qcom-nord-ahb2phy-clk-v3-0-ce5ee1073208@oss.qualcomm.com?part=2

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-11-17  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:06 [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
2026-11-17  9:06 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
2026-11-17  9:06 ` [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
2026-11-17  9:16   ` sashiko-bot [this message]
2026-11-17  9:06 ` [PATCH v3 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218467@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox