* [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord
@ 2026-11-17 9:06 Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-11-17 9:06 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Shawn Guo
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Bartosz Golaszewski, Krzysztof Kozlowski, Manivannan Sadhasivam,
Konrad Dybcio
On Nord, the register space of all the USB PHYs (the two USB3-DP QMP
PHYs and the three eUSB2 PHYs) sits behind the AHB2PHY_0 bridge, which
is gated by NE_GCC_AHB2PHY_CLK. None of the PHYs currently describe or
enable that clock, so clk_disable_unused() gates it before the PHYs are
initialized. The PHY init sequences then never reach the hardware and
the controllers fail to come up:
dwc3-qcom a600000.usb: DWC3 controller soft reset failed.
dwc3-qcom a600000.usb: error -ETIMEDOUT: failed to initialize core
xhci-hcd xhci-hcd.2.auto: can't setup: -110
As a result, USB on Nord only works when booting with clk_ignore_unused.
An earlier attempt marked the clock always-on in the NE GCC driver. This
series instead makes the PHYs consumers of the bridge clock, so it is
only kept enabled while a PHY is in use:
- Patch 1 adds a fifth "cfg_ahb" clock to the Nord QMP USB3-DP PHY
binding. No driver change is required.
- Patches 2 and 3 add a "bus" clock to the Nord eUSB2 PHY binding, and
Nord-specific match data in the snps-eusb2 driver that enables it
alongside the "ref" clock.
This should go into v7.4.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v3:
- Use an enum instead of a list of const entries for the
"qcom,nord-snps-eusb2-phy" compatible
- Pick up tags
- Link to v2: https://patch.msgid.link/20261112-qcom-nord-ahb2phy-clk-v2-0-30ad3d947217@oss.qualcomm.com
Changes in v2:
- Drop the qcom,sm8550-snps-eusb2-phy fallback from patch 2/3
- Make constraints on the number of clocks stricter in patch 1/3
- Tweak commit messages
- Add Fixes tags to DT binding patches as they actually fix existing
issues
- Link to v1: https://lore.kernel.org/all/20261008015017.3359804-1-shengchao.guo@oss.qualcomm.com/
---
Shawn Guo (3):
dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord
dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord
.../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 3 +++
.../bindings/phy/qcom,snps-eusb2-phy.yaml | 27 ++++++++++++++++++++--
drivers/phy/phy-snps-eusb2.c | 13 +++++++++++
3 files changed, 41 insertions(+), 2 deletions(-)
---
base-commit: 749a4de370409464cf8501ec5b2451df45c84eb4
change-id: 20261112-qcom-nord-ahb2phy-clk-2d21a9dcfcc2
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord
2026-11-17 9:06 [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
@ 2026-11-17 9:06 ` Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-11-17 9:06 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Shawn Guo
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Bartosz Golaszewski, Krzysztof Kozlowski
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
On Nord, the USB3-DP PHY registers are reached through the AHB2PHY_0
bridge, which is gated by NE_GCC_AHB2PHY_CLK. Describe the bridge clock
as a fifth "cfg_ahb" clock for Nord, using the same clock list as SC7180
and SDM845.
While at it: make the constraints stricter than the global settings: set
minItems to 5 as all three architectures require the cfg_ahb clock.
Fixes: 674e602140a1 ("dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Document the Nord QMP PHY")
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
[Bartosz: fix constraints]
Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
.../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
index 13e64fe510b8f..8d09e6937fef0 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
@@ -209,11 +209,13 @@ allOf:
compatible:
contains:
enum:
+ - qcom,nord-qmp-usb3-dp-phy
- qcom,sc7180-qmp-usb3-dp-phy
- qcom,sdm845-qmp-usb3-dp-phy
then:
properties:
clocks:
+ minItems: 5
maxItems: 5
clock-names:
items:
@@ -229,6 +231,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,nord-qmp-usb3-dp-phy
- qcom,x1e80100-qmp-usb3-dp-phy
- qcom,sc7180-qmp-usb3-dp-phy
- qcom,sdm845-qmp-usb3-dp-phy
--
2.47.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
2026-11-17 9:06 [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
@ 2026-11-17 9:06 ` Bartosz Golaszewski
2026-11-17 9:16 ` sashiko-bot
2026-11-17 9:06 ` [PATCH v3 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Bartosz Golaszewski
2 siblings, 1 reply; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-11-17 9:06 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Shawn Guo
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Bartosz Golaszewski, Krzysztof Kozlowski
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
On Nord, the eUSB2 PHY registers are reached through the AHB2PHY_0
bridge, which is gated by NE_GCC_AHB2PHY_CLK. Allow an optional
second "bus" clock for the AHB2PHY bridge, require it for
qcom,nord-snps-eusb2-phy, and keep other compatibles at the single
"ref" clock. Since the Nord PHY needs the second bus clock, it's not
really compatible with sm8550 so drop the fall-back. This is fine as no
DT source uses it yet.
Fixes: 4d1f3875f328 ("dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY")
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
[Bartosz: don't use the "qcom,sm8550-snps-eusb2-phy" fallback]
Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
.../bindings/phy/qcom,snps-eusb2-phy.yaml | 27 ++++++++++++++++++++--
1 file changed, 25 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
index 931cd0e7d297e..40c0b8b42182d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
@@ -19,13 +19,14 @@ properties:
- enum:
- qcom,eliza-snps-eusb2-phy
- qcom,milos-snps-eusb2-phy
- - qcom,nord-snps-eusb2-phy
- qcom,sar2130p-snps-eusb2-phy
- qcom,sdx75-snps-eusb2-phy
- qcom,sm8650-snps-eusb2-phy
- qcom,x1e80100-snps-eusb2-phy
- const: qcom,sm8550-snps-eusb2-phy
- - const: qcom,sm8550-snps-eusb2-phy
+ - enum:
+ - qcom,nord-snps-eusb2-phy
+ - qcom,sm8550-snps-eusb2-phy
reg:
maxItems: 1
@@ -34,12 +35,16 @@ properties:
const: 0
clocks:
+ minItems: 1
items:
- description: ref
+ - description: AHB2PHY bridge clock for register access
clock-names:
+ minItems: 1
items:
- const: ref
+ - const: bus
resets:
maxItems: 1
@@ -77,6 +82,24 @@ allOf:
required:
- resets
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: qcom,nord-snps-eusb2-phy
+ then:
+ properties:
+ clocks:
+ minItems: 2
+ clock-names:
+ minItems: 2
+ else:
+ properties:
+ clocks:
+ maxItems: 1
+ clock-names:
+ maxItems: 1
+
additionalProperties: false
examples:
--
2.47.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord
2026-11-17 9:06 [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
@ 2026-11-17 9:06 ` Bartosz Golaszewski
2 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2026-11-17 9:06 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Shawn Guo
Cc: linux-arm-msm, linux-phy, devicetree, linux-kernel,
Bartosz Golaszewski, Manivannan Sadhasivam, Konrad Dybcio
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
On Nord, the eUSB2 PHY registers sit behind the AHB2PHY_0 bridge, gated
by NE_GCC_AHB2PHY_CLK. When nothing else holds it, e.g. on boards
where only the USB20-only controller is in use, clk_disable_unused()
gates the bridge and PHY init accesses go nowhere:
xhci-hcd xhci-hcd.2.auto: can't setup: -110
Add Nord-specific match data that requests both "ref" and "bus" clocks,
reusing the existing Qualcomm init sequence. The bus clock is enabled
and disabled together with the ref clock in phy init/exit.
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tested-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/phy/phy-snps-eusb2.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c
index ee473b32f116d..4c70d15210c68 100644
--- a/drivers/phy/phy-snps-eusb2.c
+++ b/drivers/phy/phy-snps-eusb2.c
@@ -452,6 +452,16 @@ static const struct snps_eusb2_phy_drvdata sm8550_snps_eusb2_phy = {
.num_clks = ARRAY_SIZE(qcom_eusb2_hsphy_clock_names),
};
+static const char * const nord_eusb2_hsphy_clock_names[] = {
+ "ref", "bus",
+};
+
+static const struct snps_eusb2_phy_drvdata nord_snps_eusb2_phy = {
+ .phy_init = qcom_snps_eusb2_hsphy_init,
+ .clk_names = nord_eusb2_hsphy_clock_names,
+ .num_clks = ARRAY_SIZE(nord_eusb2_hsphy_clock_names),
+};
+
static int snps_eusb2_hsphy_init(struct phy *p)
{
struct snps_eusb2_hsphy *phy = phy_get_drvdata(p);
@@ -607,6 +617,9 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev)
static const struct of_device_id snps_eusb2_hsphy_of_match_table[] = {
{
+ .compatible = "qcom,nord-snps-eusb2-phy",
+ .data = &nord_snps_eusb2_phy,
+ }, {
.compatible = "qcom,sm8550-snps-eusb2-phy",
.data = &sm8550_snps_eusb2_phy,
}, {
--
2.47.3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
2026-11-17 9:06 ` [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
@ 2026-11-17 9:16 ` sashiko-bot
0 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-17 9:16 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-phy, devicetree, robh, conor+dt, vkoul, neil.armstrong,
olteanv
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: phy: qcom,snps-eusb2-phy: duplicated Nord if-then
conditionals
--
commit 13c4e9b2c7f49f0e94267a2da3fb8460b96d9170
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>
dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock
This commit drops the qcom,sm8550-snps-eusb2-phy fallback for
qcom,nord-snps-eusb2-phy and requires a second "bus" clock for the Nord
AHB2PHY bridge while keeping a single "ref" clock for other compatibles.
> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 931cd0e7d297e..40c0b8b42182d 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
[ ... ]
> @@ -77,6 +82,24 @@ allOf:
> required:
> - resets
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,nord-snps-eusb2-phy
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + clock-names:
> + minItems: 2
> + else:
> + properties:
> + clocks:
> + maxItems: 1
> + clock-names:
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
[Severity: Low]
This isn't a bug, but now that qcom,nord-snps-eusb2-phy no longer falls
back to qcom,sm8550-snps-eusb2-phy and differs in both clocks and required
resets, could it be split into a separate binding schema or at least have
both allOf conditionals for qcom,nord-snps-eusb2-phy combined by moving
required resets into this else branch?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-qcom-nord-ahb2phy-clk-v3-0-ce5ee1073208@oss.qualcomm.com?part=2
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-17 9:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 9:06 [PATCH v3 0/3] phy: qcom: Describe the AHB2PHY bridge clock on Nord Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord Bartosz Golaszewski
2026-11-17 9:06 ` [PATCH v3 2/3] dt-bindings: phy: qcom,snps-eusb2-phy: Add Nord bus clock Bartosz Golaszewski
2026-11-17 9:16 ` sashiko-bot
2026-11-17 9:06 ` [PATCH v3 3/3] phy: phy-snps-eusb2: Enable AHB2PHY bus clock on Nord Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox