Re: [PATCH v1] thermal: imx: Make trip point offset configurable

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 18/05/2022 11:49, Francesco Dolcini wrote:
> Hello Marco,
> 
> On Wed, May 18, 2022 at 10:55:22AM +0200, Marco Felsch wrote:
>> On 22-05-16, Francesco Dolcini wrote:
>>> Currently the imx thermal driver has a hardcoded critical temperature
>>> value offset of 5 Celsius degrees from the actual SoC maximum
>>> temperature.
>>>
>>> This affects applications and systems designed to be working on this close
>>> to the limit, but yet valid, temperature range.
>>>
>>> Given that there is no single value that will fit all the use cases make
>>> the critical trip point offset from the max temperature configurable
>>> using a newly added trip_offset module parameter, passive trip point is
>>> set to 5 Celsius degrees less than the critical. By default the
>>> system behaves exactly as before.
>>
>> I thought the conclusion of the discussion was to use a dt-property?
>> Since it is device and/or environment specific.
> 
> Daniel proposed to use a module parameter [0], but if you prefer a
> dt-property I can change this. I would keep the same semantic (offset
> from max temperature to compute the critical trip point).
> 
> [0] https://lore.kernel.org/all/7f5a919c-2fa1-a463-1f6b-6b531d5ee27d@linaro.org/


It would have been easier if the imx6/7 platforms were defining the 
thermal zones in their DT ...


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog