From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
l.stach@pengutronix.de, linux-pm@vger.kernel.org
Cc: Amit Kucheria <amitk@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
Tim Harvey <tharvey@gateworks.com>,
Jon Nettleton <jon@solid-run.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1] thermal: imx: Make trip point offset configurable
Date: Tue, 17 May 2022 17:29:25 +0200 [thread overview]
Message-ID: <20220517152925.GA32004@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <20220516190001.147919-1-francesco.dolcini@toradex.com>
Hello all,
On Mon, May 16, 2022 at 09:00:01PM +0200, Francesco Dolcini wrote:
> Currently the imx thermal driver has a hardcoded critical temperature
> value offset of 5 Celsius degrees from the actual SoC maximum
> temperature.
>
> This affects applications and systems designed to be working on this close
> to the limit, but yet valid, temperature range.
>
> Given that there is no single value that will fit all the use cases make
> the critical trip point offset from the max temperature configurable
> using a newly added trip_offset module parameter, passive trip point is
> set to 5 Celsius degrees less than the critical. By default the
> system behaves exactly as before.
In your opinion this commit could be eligible as a fix, e.g.
Fixes: a2291badc355 ("imx: thermal: use CPU temperature grade info for thresholds")
?
From my application point of view this is a fix, but on the other hand
not sure if a premature emergency shutdown for a specific application
is considered a "bug".
Francesco
next prev parent reply other threads:[~2022-05-17 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 19:00 [PATCH v1] thermal: imx: Make trip point offset configurable Francesco Dolcini
2022-05-16 19:06 ` Ahmad Fatoum
2022-05-16 19:16 ` Francesco Dolcini
2022-05-17 4:36 ` Ahmad Fatoum
2022-05-17 15:29 ` Francesco Dolcini [this message]
2022-05-18 8:55 ` Marco Felsch
2022-05-18 9:49 ` Francesco Dolcini
2022-05-18 10:10 ` Daniel Lezcano
2022-05-23 14:35 ` Francesco Dolcini
2022-05-24 8:35 ` Marco Felsch
2022-05-24 10:07 ` Francesco Dolcini
2022-05-24 13:17 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517152925.GA32004@francesco-nb.int.toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=festevam@gmail.com \
--cc=jon@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox