Linux Power Management development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Chris Bainbridge <chris.bainbridge@gmail.com>,
	Saravana Kannan <saravanak@google.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [RFT][PATCH v4 0/2] PM: sleep: Handle async suppliers like parents and async consumers like children
Date: Fri, 27 Jun 2025 09:01:30 -0500	[thread overview]
Message-ID: <0412561d-6ed3-4823-b510-8600fd4fd1fa@amd.com> (raw)
In-Reply-To: <CAJZ5v0iJ65xxuHtJrWp1sC76FUzPHNpXB+xtHB=e4qTRSgAC4w@mail.gmail.com>

On 6/27/2025 5:40 AM, Rafael J. Wysocki wrote:
> On Fri, Jun 27, 2025 at 12:28 AM Mario Limonciello
> <mario.limonciello@amd.com> wrote:
>>
>> On 6/26/2025 4:46 AM, Ulf Hansson wrote:
>>> On Mon, 23 Jun 2025 at 14:55, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>>>>
>>>> Hi Everyone,
>>>>
>>>> These two patches complement the recently made PM core changes related to
>>>> the async suspend and resume of devices.  They should apply on top of
>>>> 6.16-rc3.
>>>>
>>>> They were sent along with the other changes mentioned above:
>>>>
>>>> https://lore.kernel.org/linux-pm/2229735.Mh6RI2rZIc@rjwysocki.net/
>>>> https://lore.kernel.org/linux-pm/2651185.Lt9SDvczpP@rjwysocki.net/
>>>>
>>>> (and this is v4 because they have been rebased in the meantime), but they don't
>>>> make any difference on my test-bed x86 systems, so I'd appreciate a confirmation
>>>> that they are actually needed on ARM (or another architecture using DT).
>>>>
>>>> Thanks!
>>>
>>> Hi Rafael,
>>>
>>> I haven't yet got the time to test these, but the code looks good to
>>> me, so feel free to add for the series:
>>>
>>> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
>>>
>>> Kind regards
>>> Uffe
>>
>> I passed this series to some internal guys to test on a wide variety of
>> AMD x86 hardware.  The initial testing looks good.
>> Will keep you apprised if anything pops up.
> 
> Thanks!
> 
> It would also help if you could check whether or not there is any
> measurable performance (that is, system suspend and resume time)
> difference between "before" and "after".

Sure thing.

Just to make sure we have an aligned measurement methodology:

I asked them to do this both with and without the patches.

* set /sys/power/pm_debug_messages before running and then capture all 
the timing prints.
* add up all suspend events and get a total
* add up all resume events and get a total
* repeat 5 times
* calculate averages for the 5 runs

  reply	other threads:[~2025-06-27 14:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 12:44 [RFT][PATCH v4 0/2] PM: sleep: Handle async suppliers like parents and async consumers like children Rafael J. Wysocki
2025-06-23 12:54 ` [RFT][PATCH v4 1/2] PM: sleep: Make async resume handle " Rafael J. Wysocki
2025-06-23 12:55 ` [RFT][PATCH v4 2/2] PM: sleep: Make async suspend handle suppliers like parents Rafael J. Wysocki
2025-06-26  9:46 ` [RFT][PATCH v4 0/2] PM: sleep: Handle async suppliers like parents and async consumers like children Ulf Hansson
2025-06-26 22:28   ` Mario Limonciello
2025-06-27 10:40     ` Rafael J. Wysocki
2025-06-27 14:01       ` Mario Limonciello [this message]
2025-06-27 17:31         ` Rafael J. Wysocki
2025-06-28  5:31           ` Mario Limonciello
2025-06-30 13:12 ` Sudeep Holla
2025-07-03 14:51   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0412561d-6ed3-4823-b510-8600fd4fd1fa@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=chris.bainbridge@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=saravanak@google.com \
    --cc=sudeep.holla@arm.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox