From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mario Limonciello <mario.limonciello@amd.com>,
Chris Bainbridge <chris.bainbridge@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Saravana Kannan <saravanak@google.com>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: [RFT][PATCH v4 2/2] PM: sleep: Make async suspend handle suppliers like parents
Date: Mon, 23 Jun 2025 14:55:05 +0200 [thread overview]
Message-ID: <3384525.44csPzL39Z@rjwysocki.net> (raw)
In-Reply-To: <5011988.GXAFRqVoOG@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Avoid starting "async" suspend processing upfront for devices that have
consumers and start "async" suspend processing for a device's suppliers
right after suspending the device itself.
Suggested-by: Saravana Kannan <saravanak@google.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
v3 -> v4: Rebase and update the changelog.
---
drivers/base/power/main.c | 37 +++++++++++++++++++++++++++++++------
1 file changed, 31 insertions(+), 6 deletions(-)
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -1257,10 +1257,15 @@
return false;
}
- return true;
+ /*
+ * Since this function is required to run under dpm_list_mtx, the
+ * list_empty() below will only return true if the device's list of
+ * consumers is actually empty before calling it.
+ */
+ return list_empty(&dev->links.consumers);
}
-static void dpm_async_suspend_parent(struct device *dev, async_func_t func)
+static bool dpm_async_suspend_parent(struct device *dev, async_func_t func)
{
guard(mutex)(&dpm_list_mtx);
@@ -1272,11 +1277,31 @@
* deleted before it.
*/
if (!device_pm_initialized(dev))
- return;
+ return false;
/* Start processing the device's parent if it is "async". */
if (dev->parent)
dpm_async_with_cleanup(dev->parent, func);
+
+ return true;
+}
+
+static void dpm_async_suspend_superior(struct device *dev, async_func_t func)
+{
+ struct device_link *link;
+ int idx;
+
+ if (!dpm_async_suspend_parent(dev, func))
+ return;
+
+ idx = device_links_read_lock();
+
+ /* Start processing the device's "async" suppliers. */
+ list_for_each_entry_rcu(link, &dev->links.suppliers, c_node)
+ if (READ_ONCE(link->status) != DL_STATE_DORMANT)
+ dpm_async_with_cleanup(link->supplier, func);
+
+ device_links_read_unlock(idx);
}
/**
@@ -1400,7 +1425,7 @@
if (error || async_error)
return error;
- dpm_async_suspend_parent(dev, async_suspend_noirq);
+ dpm_async_suspend_superior(dev, async_suspend_noirq);
return 0;
}
@@ -1596,7 +1621,7 @@
if (error || async_error)
return error;
- dpm_async_suspend_parent(dev, async_suspend_late);
+ dpm_async_suspend_superior(dev, async_suspend_late);
return 0;
}
@@ -1887,7 +1912,7 @@
if (error || async_error)
return error;
- dpm_async_suspend_parent(dev, async_suspend);
+ dpm_async_suspend_superior(dev, async_suspend);
return 0;
}
next prev parent reply other threads:[~2025-06-23 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 12:44 [RFT][PATCH v4 0/2] PM: sleep: Handle async suppliers like parents and async consumers like children Rafael J. Wysocki
2025-06-23 12:54 ` [RFT][PATCH v4 1/2] PM: sleep: Make async resume handle " Rafael J. Wysocki
2025-06-23 12:55 ` Rafael J. Wysocki [this message]
2025-06-26 9:46 ` [RFT][PATCH v4 0/2] PM: sleep: Handle async suppliers like parents and async " Ulf Hansson
2025-06-26 22:28 ` Mario Limonciello
2025-06-27 10:40 ` Rafael J. Wysocki
2025-06-27 14:01 ` Mario Limonciello
2025-06-27 17:31 ` Rafael J. Wysocki
2025-06-28 5:31 ` Mario Limonciello
2025-06-30 13:12 ` Sudeep Holla
2025-07-03 14:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3384525.44csPzL39Z@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=chris.bainbridge@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=saravanak@google.com \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox