From: Daniel Baluta <daniel.baluta@nxp.com>
To: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
Abel Vesa <abel.vesa@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC] cpufreq: Add imx-cpufreq-dt driver
Date: Thu, 25 Apr 2019 11:38:40 +0000 [thread overview]
Message-ID: <0e33e8f8e7f5aae410750a815dffc0cd8d2b1d2e.camel@nxp.com> (raw)
In-Reply-To: <83a3ade389239bd492ee646aa4868c5e37e65434.1556187603.git.leonard.crestez@nxp.com>
Minor comment,
<snip>
> + u32 (*check_speed_grading)(struct device *);
> + int ret;
> +
> + np = of_find_node_by_path("/");
Indentation looks strange here ^
> + id = of_match_node(imx_cpufreq_dt_match_list, np);
> + of_node_put(np);
> + if (!id)
> + return -ENODEV;
>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Baluta <daniel.baluta@nxp.com>
To: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
Abel Vesa <abel.vesa@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [RFC] cpufreq: Add imx-cpufreq-dt driver
Date: Thu, 25 Apr 2019 11:38:40 +0000 [thread overview]
Message-ID: <0e33e8f8e7f5aae410750a815dffc0cd8d2b1d2e.camel@nxp.com> (raw)
Message-ID: <20190425113840.Gj2sIep330gwMXp3NnUfaWa80VFqpmadQCaALECCqxg@z> (raw)
In-Reply-To: <83a3ade389239bd492ee646aa4868c5e37e65434.1556187603.git.leonard.crestez@nxp.com>
Minor comment,
<snip>
> + u32 (*check_speed_grading)(struct device *);
> + int ret;
> +
> + np = of_find_node_by_path("/");
Indentation looks strange here ^
> + id = of_match_node(imx_cpufreq_dt_match_list, np);
> + of_node_put(np);
> + if (!id)
> + return -ENODEV;
>
next prev parent reply other threads:[~2019-04-25 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 10:29 [RFC] cpufreq: Add imx-cpufreq-dt driver Leonard Crestez
2019-04-25 10:29 ` Leonard Crestez
2019-04-25 10:32 ` Viresh Kumar
2019-04-25 10:32 ` Viresh Kumar
2019-04-25 11:38 ` Daniel Baluta [this message]
2019-04-25 11:38 ` Daniel Baluta
2019-04-26 9:47 ` Lucas Stach
2019-04-26 9:47 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e33e8f8e7f5aae410750a815dffc0cd8d2b1d2e.camel@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox