* [PATCH] x86/acpi: fix incorrect placement of __initdata tag
@ 2013-09-30 13:16 Bartlomiej Zolnierkiewicz
2013-09-30 14:24 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-30 13:16 UTC (permalink / raw)
To: Len Brown
Cc: Pavel Machek, Rafael J. Wysocki, linux-pm, linux-kernel,
Kyungmin Park
__initdata tag should be placed between the variable name and equal
sign for the variable to be placed in the intended .init.data section.
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/x86/kernel/acpi/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 1f7c074..6c0b43b 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -695,7 +695,7 @@ static int __init acpi_parse_sbf(struct acpi_table_header *table)
#ifdef CONFIG_HPET_TIMER
#include <asm/hpet.h>
-static struct __initdata resource *hpet_res;
+static struct resource *hpet_res __initdata;
static int __init acpi_parse_hpet(struct acpi_table_header *table)
{
--
1.8.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] x86/acpi: fix incorrect placement of __initdata tag
2013-09-30 13:16 [PATCH] x86/acpi: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
@ 2013-09-30 14:24 ` Alan Stern
2013-09-30 15:27 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2013-09-30 14:24 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Len Brown, Pavel Machek, Rafael J. Wysocki, linux-pm,
linux-kernel, Kyungmin Park
On Mon, 30 Sep 2013, Bartlomiej Zolnierkiewicz wrote:
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
The line you are changing does not have an equals sign. Therefore,
according to your own patch description, the patch is incorrect. :-)
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/x86/kernel/acpi/boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 1f7c074..6c0b43b 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -695,7 +695,7 @@ static int __init acpi_parse_sbf(struct acpi_table_header *table)
> #ifdef CONFIG_HPET_TIMER
> #include <asm/hpet.h>
>
> -static struct __initdata resource *hpet_res;
> +static struct resource *hpet_res __initdata;
>
> static int __init acpi_parse_hpet(struct acpi_table_header *table)
> {
Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] x86/acpi: fix incorrect placement of __initdata tag
2013-09-30 14:24 ` Alan Stern
@ 2013-09-30 15:27 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2013-09-30 15:27 UTC (permalink / raw)
To: Alan Stern
Cc: Len Brown, Pavel Machek, Rafael J. Wysocki, linux-pm,
linux-kernel, Kyungmin Park
On Monday, September 30, 2013 10:24:41 AM Alan Stern wrote:
> On Mon, 30 Sep 2013, Bartlomiej Zolnierkiewicz wrote:
>
> > __initdata tag should be placed between the variable name and equal
> > sign for the variable to be placed in the intended .init.data section.
>
> The line you are changing does not have an equals sign. Therefore,
> according to your own patch description, the patch is incorrect. :-)
Uh, indeed, copypasta is bad. :)
Thanks for noticing, I'll post v2 shortly.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > ---
> > arch/x86/kernel/acpi/boot.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> > index 1f7c074..6c0b43b 100644
> > --- a/arch/x86/kernel/acpi/boot.c
> > +++ b/arch/x86/kernel/acpi/boot.c
> > @@ -695,7 +695,7 @@ static int __init acpi_parse_sbf(struct acpi_table_header *table)
> > #ifdef CONFIG_HPET_TIMER
> > #include <asm/hpet.h>
> >
> > -static struct __initdata resource *hpet_res;
> > +static struct resource *hpet_res __initdata;
> >
> > static int __init acpi_parse_hpet(struct acpi_table_header *table)
> > {
>
> Alan Stern
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-30 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-30 13:16 [PATCH] x86/acpi: fix incorrect placement of __initdata tag Bartlomiej Zolnierkiewicz
2013-09-30 14:24 ` Alan Stern
2013-09-30 15:27 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox