* [PATCH] drivers: base: power: Use of_clk_get_parent_count()
@ 2019-05-25 12:01 Kefeng Wang
2019-05-27 10:34 ` Rafael J. Wysocki
2019-05-27 11:08 ` Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Kefeng Wang @ 2019-05-25 12:01 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman
Cc: linux-pm, linux-kernel, Kefeng Wang
Use of_clk_get_parent_count() instead of open coding.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/base/power/clock_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 59d19dd64928..9c7e83267eac 100644
--- a/drivers/base/power/clock_ops.c
+++ b/drivers/base/power/clock_ops.c
@@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
if (!dev || !dev->of_node)
return -EINVAL;
- count = of_count_phandle_with_args(dev->of_node, "clocks",
- "#clock-cells");
+ count = of_clk_get_parent_count(dev->of_node);
if (count <= 0)
return -ENODEV;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()
2019-05-25 12:01 [PATCH] drivers: base: power: Use of_clk_get_parent_count() Kefeng Wang
@ 2019-05-27 10:34 ` Rafael J. Wysocki
2019-05-27 11:08 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2019-05-27 10:34 UTC (permalink / raw)
To: Kefeng Wang
Cc: Len Brown, Greg Kroah-Hartman, linux-pm, linux-kernel,
Stephen Boyd, Jon Hunter, Geert Uytterhoeven
On Saturday, May 25, 2019 2:01:55 PM CEST Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/base/power/clock_ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index 59d19dd64928..9c7e83267eac 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
> if (!dev || !dev->of_node)
> return -EINVAL;
>
> - count = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + count = of_clk_get_parent_count(dev->of_node);
> if (count <= 0)
> return -ENODEV;
>
>
I need someone to look at this from DT perspective.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()
2019-05-25 12:01 [PATCH] drivers: base: power: Use of_clk_get_parent_count() Kefeng Wang
2019-05-27 10:34 ` Rafael J. Wysocki
@ 2019-05-27 11:08 ` Geert Uytterhoeven
2019-05-27 11:57 ` Kefeng Wang
2019-05-27 12:05 ` [PATCH v2] " Kefeng Wang
1 sibling, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-05-27 11:08 UTC (permalink / raw)
To: Kefeng Wang
Cc: Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman, Linux PM list,
Linux Kernel Mailing List
Hi Kefeng,
On Sat, May 25, 2019 at 1:54 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Thanks for your patch!
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
> if (!dev || !dev->of_node)
> return -EINVAL;
>
> - count = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + count = of_clk_get_parent_count(dev->of_node);
> if (count <= 0)
> return -ENODEV;
Given of_clk_get_parent_count() is provided by <linux/of_clk.h>, I think
you should add an include for that.
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers: base: power: Use of_clk_get_parent_count()
2019-05-27 11:08 ` Geert Uytterhoeven
@ 2019-05-27 11:57 ` Kefeng Wang
2019-05-27 12:05 ` [PATCH v2] " Kefeng Wang
1 sibling, 0 replies; 6+ messages in thread
From: Kefeng Wang @ 2019-05-27 11:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman, Linux PM list,
Linux Kernel Mailing List
On 2019/5/27 19:08, Geert Uytterhoeven wrote:
> Hi Kefeng,
>
> On Sat, May 25, 2019 at 1:54 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Use of_clk_get_parent_count() instead of open coding.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> Thanks for your patch!
>
>> --- a/drivers/base/power/clock_ops.c
>> +++ b/drivers/base/power/clock_ops.c
>> @@ -195,8 +195,7 @@ int of_pm_clk_add_clks(struct device *dev)
>> if (!dev || !dev->of_node)
>> return -EINVAL;
>>
>> - count = of_count_phandle_with_args(dev->of_node, "clocks",
>> - "#clock-cells");
>> + count = of_clk_get_parent_count(dev->of_node);
>> if (count <= 0)
>> return -ENODEV;
>
> Given of_clk_get_parent_count() is provided by <linux/of_clk.h>, I think
> you should add an include for that.
Thanks for your kind suggestion, v2 has been sent with the head and your reviewed-by.
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
> Geert
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] drivers: base: power: Use of_clk_get_parent_count()
2019-05-27 11:08 ` Geert Uytterhoeven
2019-05-27 11:57 ` Kefeng Wang
@ 2019-05-27 12:05 ` Kefeng Wang
2019-05-31 9:28 ` Rafael J. Wysocki
1 sibling, 1 reply; 6+ messages in thread
From: Kefeng Wang @ 2019-05-27 12:05 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown, Greg Kroah-Hartman
Cc: linux-pm, linux-kernel, Kefeng Wang, Geert Uytterhoeven
Use of_clk_get_parent_count() instead of open coding.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/base/power/clock_ops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
index 59d19dd64928..3e84e3085d43 100644
--- a/drivers/base/power/clock_ops.c
+++ b/drivers/base/power/clock_ops.c
@@ -12,6 +12,7 @@
#include <linux/pm_clock.h>
#include <linux/clk.h>
#include <linux/clkdev.h>
+#include <linux/of_clk.h>
#include <linux/slab.h>
#include <linux/err.h>
#include <linux/pm_domain.h>
@@ -195,8 +196,7 @@ int of_pm_clk_add_clks(struct device *dev)
if (!dev || !dev->of_node)
return -EINVAL;
- count = of_count_phandle_with_args(dev->of_node, "clocks",
- "#clock-cells");
+ count = of_clk_get_parent_count(dev->of_node);
if (count <= 0)
return -ENODEV;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drivers: base: power: Use of_clk_get_parent_count()
2019-05-27 12:05 ` [PATCH v2] " Kefeng Wang
@ 2019-05-31 9:28 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2019-05-31 9:28 UTC (permalink / raw)
To: Kefeng Wang
Cc: Len Brown, Greg Kroah-Hartman, linux-pm, linux-kernel,
Geert Uytterhoeven
On Monday, May 27, 2019 2:05:35 PM CEST Kefeng Wang wrote:
> Use of_clk_get_parent_count() instead of open coding.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/base/power/clock_ops.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index 59d19dd64928..3e84e3085d43 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -12,6 +12,7 @@
> #include <linux/pm_clock.h>
> #include <linux/clk.h>
> #include <linux/clkdev.h>
> +#include <linux/of_clk.h>
> #include <linux/slab.h>
> #include <linux/err.h>
> #include <linux/pm_domain.h>
> @@ -195,8 +196,7 @@ int of_pm_clk_add_clks(struct device *dev)
> if (!dev || !dev->of_node)
> return -EINVAL;
>
> - count = of_count_phandle_with_args(dev->of_node, "clocks",
> - "#clock-cells");
> + count = of_clk_get_parent_count(dev->of_node);
> if (count <= 0)
> return -ENODEV;
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-31 9:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-25 12:01 [PATCH] drivers: base: power: Use of_clk_get_parent_count() Kefeng Wang
2019-05-27 10:34 ` Rafael J. Wysocki
2019-05-27 11:08 ` Geert Uytterhoeven
2019-05-27 11:57 ` Kefeng Wang
2019-05-27 12:05 ` [PATCH v2] " Kefeng Wang
2019-05-31 9:28 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox