Re: Commit 0c4cae1bc ("PM: hibernate: Avoid missing wakeup events during hibernation") prevents my laptop from hibernating

Re: Commit 0c4cae1bc ("PM: hibernate: Avoid missing wakeup events during hibernation") prevents my laptop from hibernating

[Wysocki, Rafael J]

[Resend with the linux-pm address fixed]

On 4/9/2024 10:40 PM, Kenneth Crudup wrote:
>
> While in the process of trying to fix kernel 6.8 hibernate issues on 
> my laptop (including bisecting why my laptop crashes on resume from 
> hibernate on my machine (a Dell XPS 9320, i7-1280P, and using a 
> swapfile)), I'd determined the named commit prevents hibernation from 
> occurring in the first place.
>
> Are there any other reports of this?
>

There are.  Please see

https://patchwork.kernel.org/project/linux-pm/patch/878r1tpd6u.fsf_-_@gmail.com/


> What do you need from me to help fix this issue? I'm assuming that 
> whatever (pending?) wakeup event that's causing the rejection does not 
> seem to hinder previous kernels from having sucessful suspend/resume 
> cycles.
>

If the patch above does not address the issue for you, the problematic 
commit will have to be reverted I'm afraid.

Thanks!

Re: Commit 0c4cae1bc ("PM: hibernate: Avoid missing wakeup events during hibernation") prevents my laptop from hibernating

[Kenneth Crudup]

Well, the good news is the patch in the commit fixes the "bailing out of 
hibernate" issue.

(The bad news is resume from a hibernate still fails, but that's an 
issue to be bisected later)

-Kenny

On 4/10/24 12:00, Wysocki, Rafael J wrote:
> [Resend with the linux-pm address fixed]
> 
> On 4/9/2024 10:40 PM, Kenneth Crudup wrote:
>>
>> While in the process of trying to fix kernel 6.8 hibernate issues on 
>> my laptop (including bisecting why my laptop crashes on resume from 
>> hibernate on my machine (a Dell XPS 9320, i7-1280P, and using a 
>> swapfile)), I'd determined the named commit prevents hibernation from 
>> occurring in the first place.
>>
>> Are there any other reports of this?
>>
> 
> There are.  Please see
> 
> https://patchwork.kernel.org/project/linux-pm/patch/878r1tpd6u.fsf_-_@gmail.com/
> 
> 
>> What do you need from me to help fix this issue? I'm assuming that 
>> whatever (pending?) wakeup event that's causing the rejection does not 
>> seem to hinder previous kernels from having sucessful suspend/resume 
>> cycles.
>>
> 
> If the patch above does not address the issue for you, the problematic 
> commit will have to be reverted I'm afraid.
> 
> Thanks!
> 
> 

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange 
County CA

Re: Commit 0c4cae1bc ("PM: hibernate: Avoid missing wakeup events during hibernation") prevents my laptop from hibernating

[Rafael J. Wysocki]

On Thu, Apr 11, 2024 at 8:26 AM Kenneth Crudup <kenny@panix.com> wrote:
>
>
> Well, the good news is the patch in the commit fixes the "bailing out of
> hibernate" issue.

Good, thanks for the confirmation!

This patch should be on its way to the mainline now.

> (The bad news is resume from a hibernate still fails, but that's an
> issue to be bisected later)

Well, sorry about that.