[PATCH] PM / OPP: Make OPP invisible to users in Kconfig

[PATCH] PM / OPP: Make OPP invisible to users in Kconfig

[Mark Brown]

From: Mark Brown <broonie@linaro.org>

The OPP code is an in kernel library selected by its users, there is no
no architecture code required to implement it and enabling it without a
user just increases the kernel size. Since the users select rather than
depend on it just remove the ability to directly set the option from
Kconfig.

Signed-off-by: Mark Brown <broonie@linaro.org>
---

This leaves the ARCH_HAS_OPP symbol since removing that requires
updating the relevant architectures, if this is OK I can sumbit a
followup patch cleaning that up.

 kernel/power/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 2fac9cc79b3d..9a83d780facd 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -257,8 +257,7 @@ config ARCH_HAS_OPP
 	bool
 
 config PM_OPP
-	bool "Operating Performance Point (OPP) Layer library"
-	depends on ARCH_HAS_OPP
+	bool
 	---help---
 	  SOCs have a standard set of tuples consisting of frequency and
 	  voltage pairs that the device will support per voltage domain. This
-- 
2.0.0.rc2

Re: [PATCH] PM / OPP: Make OPP invisible to users in Kconfig

[Nishanth Menon]

On Fri, May 9, 2014 at 1:18 PM, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The OPP code is an in kernel library selected by its users, there is no
> no architecture code required to implement it and enabling it without a
> user just increases the kernel size. Since the users select rather than
> depend on it just remove the ability to directly set the option from
> Kconfig.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> This leaves the ARCH_HAS_OPP symbol since removing that requires
> updating the relevant architectures, if this is OK I can sumbit a
> followup patch cleaning that up.
>

Acked-by: Nishanth Menon <nm@ti.com>
>  kernel/power/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index 2fac9cc79b3d..9a83d780facd 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -257,8 +257,7 @@ config ARCH_HAS_OPP
>         bool
>
>  config PM_OPP
> -       bool "Operating Performance Point (OPP) Layer library"
> -       depends on ARCH_HAS_OPP
> +       bool
>         ---help---
>           SOCs have a standard set of tuples consisting of frequency and
>           voltage pairs that the device will support per voltage domain. This
> --
> 2.0.0.rc2
>

Re: [PATCH] PM / OPP: Make OPP invisible to users in Kconfig

[Viresh Kumar]

On 9 May 2014 23:48, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The OPP code is an in kernel library selected by its users, there is no
> no architecture code required to implement it and enabling it without a

s/no no/no

> user just increases the kernel size. Since the users select rather than
> depend on it just remove the ability to directly set the option from
> Kconfig.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> This leaves the ARCH_HAS_OPP symbol since removing that requires
> updating the relevant architectures, if this is OK I can sumbit a
> followup patch cleaning that up.
>
>  kernel/power/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Re: [PATCH] PM / OPP: Make OPP invisible to users in Kconfig

[Rafael J. Wysocki]

On Monday, May 12, 2014 09:40:46 AM Viresh Kumar wrote:
> On 9 May 2014 23:48, Mark Brown <broonie@kernel.org> wrote:
> > From: Mark Brown <broonie@linaro.org>
> >
> > The OPP code is an in kernel library selected by its users, there is no
> > no architecture code required to implement it and enabling it without a
> 
> s/no no/no
> 
> > user just increases the kernel size. Since the users select rather than
> > depend on it just remove the ability to directly set the option from
> > Kconfig.
> >
> > Signed-off-by: Mark Brown <broonie@linaro.org>
> > ---
> >
> > This leaves the ARCH_HAS_OPP symbol since removing that requires
> > updating the relevant architectures, if this is OK I can sumbit a
> > followup patch cleaning that up.
> >
> >  kernel/power/Kconfig | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Queued up for 3.16, thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.