* [PATCH] cpufreq: s5pv210: Remove spurious __init annotation
@ 2014-08-27 11:00 Mark Brown
2014-08-27 11:04 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2014-08-27 11:00 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: linux-pm, linaro-kernel, linux-samsung-soc, Mark Brown
From: Mark Brown <broonie@linaro.org>
Since this is a platform driver and can be probed at any time we can't
annotate funtions in the probe path as __init, the code can't safely be
discarded at the end of kernel init.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index 9a68225a757e..3f9791f07b8e 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
return val >> 8;
}
-static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
+static int s5pv210_cpu_init(struct cpufreq_policy *policy)
{
unsigned long mem_type;
int ret;
--
2.1.0.rc1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: s5pv210: Remove spurious __init annotation
2014-08-27 11:00 [PATCH] cpufreq: s5pv210: Remove spurious __init annotation Mark Brown
@ 2014-08-27 11:04 ` Viresh Kumar
2014-08-27 23:52 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2014-08-27 11:04 UTC (permalink / raw)
To: Mark Brown
Cc: Rafael J. Wysocki, linux-samsung-soc, Lists linaro-kernel,
Mark Brown, linux-pm@vger.kernel.org
On 27 August 2014 16:30, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Since this is a platform driver and can be probed at any time we can't
> annotate funtions in the probe path as __init, the code can't safely be
> discarded at the end of kernel init.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
> drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index 9a68225a757e..3f9791f07b8e 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
> return val >> 8;
> }
>
> -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
> {
> unsigned long mem_type;
> int ret;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: s5pv210: Remove spurious __init annotation
2014-08-27 11:04 ` Viresh Kumar
@ 2014-08-27 23:52 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2014-08-27 23:52 UTC (permalink / raw)
To: Viresh Kumar
Cc: Mark Brown, linux-samsung-soc, Lists linaro-kernel, Mark Brown,
linux-pm@vger.kernel.org
On Wednesday, August 27, 2014 04:34:28 PM Viresh Kumar wrote:
> On 27 August 2014 16:30, Mark Brown <broonie@kernel.org> wrote:
> > From: Mark Brown <broonie@linaro.org>
> >
> > Since this is a platform driver and can be probed at any time we can't
> > annotate funtions in the probe path as __init, the code can't safely be
> > discarded at the end of kernel init.
> >
> > Signed-off-by: Mark Brown <broonie@linaro.org>
> > ---
> > drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> > index 9a68225a757e..3f9791f07b8e 100644
> > --- a/drivers/cpufreq/s5pv210-cpufreq.c
> > +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> > @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
> > return val >> 8;
> > }
> >
> > -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> > +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
> > {
> > unsigned long mem_type;
> > int ret;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Queued up for 3.17-rc3, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-27 23:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 11:00 [PATCH] cpufreq: s5pv210: Remove spurious __init annotation Mark Brown
2014-08-27 11:04 ` Viresh Kumar
2014-08-27 23:52 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox