* [PATCH] power: supply: max14656: Export I2C and OF device ID as module aliases
@ 2017-01-25 13:38 Javier Martinez Canillas
2017-01-29 15:43 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-01-25 13:38 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Sebastian Reichel, linux-pm
If the driver is built as a module, I2C module alias information is not
filled so the module won't be autoloaded. Export the I2C and OF devices
ID to the module by using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/power/supply/max14656_charger_detector.ko | grep alias
$
After this patch:
$ modinfo drivers/power/supply/max14656_charger_detector.ko | grep alias
alias: i2c:max14656
alias: of:N*T*Cmaxim,max14656C*
alias: of:N*T*Cmaxim,max14656
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/power/supply/max14656_charger_detector.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c
index 80f8e5c1b4ec..b91b1d2999dc 100644
--- a/drivers/power/supply/max14656_charger_detector.c
+++ b/drivers/power/supply/max14656_charger_detector.c
@@ -305,11 +305,13 @@ static const struct i2c_device_id max14656_id[] = {
{ "max14656", 0 },
{}
};
+MODULE_DEVICE_TABLE(i2c, max14656_id);
static const struct of_device_id max14656_match_table[] = {
{ .compatible = "maxim,max14656", },
{}
};
+MODULE_DEVICE_TABLE(of, max14656_match_table);
static struct i2c_driver max14656_i2c_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] power: supply: max14656: Export I2C and OF device ID as module aliases
2017-01-25 13:38 [PATCH] power: supply: max14656: Export I2C and OF device ID as module aliases Javier Martinez Canillas
@ 2017-01-29 15:43 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2017-01-29 15:43 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
Hi Javier,
On Wed, Jan 25, 2017 at 10:38:55AM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, I2C module alias information is not
> filled so the module won't be autoloaded. Export the I2C and OF devices
> ID to the module by using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/power/supply/max14656_charger_detector.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/power/supply/max14656_charger_detector.ko | grep alias
> alias: i2c:max14656
> alias: of:N*T*Cmaxim,max14656C*
> alias: of:N*T*Cmaxim,max14656
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Thanks, queued into power-supply's for-next.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-29 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-25 13:38 [PATCH] power: supply: max14656: Export I2C and OF device ID as module aliases Javier Martinez Canillas
2017-01-29 15:43 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox