public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Hans Wennborg <hans@hanshq.net>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x
Date: Wed, 06 Aug 2014 22:35:46 +0200	[thread overview]
Message-ID: <1494298.av10nJMuYA@vostro.rjw.lan> (raw)
In-Reply-To: <1407300108-32186-1-git-send-email-hans@hanshq.net>

On Tuesday, August 05, 2014 09:41:48 PM Hans Wennborg wrote:
> The prefix suggests the number should be printed in hex, so use
> the %x specifier to do that.
> 
> Found by using regex suggested by Joe Perches.
> 
> Signed-off-by: Hans Wennborg <hans@hanshq.net>

This triggers a build warning related to the formats.  Care to fix up?

> ---
>  drivers/cpufreq/speedstep-smi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/speedstep-smi.c b/drivers/cpufreq/speedstep-smi.c
> index 8635eec..fda9beb 100644
> --- a/drivers/cpufreq/speedstep-smi.c
> +++ b/drivers/cpufreq/speedstep-smi.c
> @@ -324,8 +324,8 @@ static int __init speedstep_init(void)
>  		return -ENODEV;
>  	}
>  
> -	pr_debug("signature:0x%.8ulx, command:0x%.8ulx, "
> -		"event:0x%.8ulx, perf_level:0x%.8ulx.\n",
> +	pr_debug("signature:0x%.8lx, command:0x%.8lx, "
> +		"event:0x%.8lx, perf_level:0x%.8lx.\n",
>  		ist_info.signature, ist_info.command,
>  		ist_info.event, ist_info.perf_level);
>  
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2014-08-06 20:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-06  4:41 [PATCH 02/15] cpufreq: fix decimal printf format specifiers prefixed with 0x Hans Wennborg
2014-08-06 20:35 ` Rafael J. Wysocki [this message]
2014-08-07  5:52   ` [PATCH 1/1] cpufreq: fix decimal printf " Hans Wennborg
2014-08-07  5:53   ` [PATCH 02/15] cpufreq: fix decimal printf format " Hans Wennborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494298.av10nJMuYA@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=hans@hanshq.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox