[PATCH] power: qos: Export pm_qos_update_request_timeout()

[PATCH] power: qos: Export pm_qos_update_request_timeout()

[Hareesh Gundu]

Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout,
so that it can be usable from modules similar to the
pm_qos_update_request().

Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
---
 kernel/power/qos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/power/qos.c b/kernel/power/qos.c
index 9d75039..3f501b4 100644
--- a/kernel/power/qos.c
+++ b/kernel/power/qos.c
@@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
 
 	schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
 }
+EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
 
 /**
  * pm_qos_remove_request - modifies an existing qos request
-- 
1.9.1

Re: [PATCH] power: qos: Export pm_qos_update_request_timeout()

[Rafael J. Wysocki]

On Tue, Dec 5, 2017 at 11:45 AM, Hareesh Gundu <hareeshg@codeaurora.org> wrote:
> Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout,
> so that it can be usable from modules similar to the
> pm_qos_update_request().
>
> Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>

I'd rather see a modular user of this along with the export.

> ---
>  kernel/power/qos.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index 9d75039..3f501b4 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
>
>         schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
>  }
> +EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
>
>  /**
>   * pm_qos_remove_request - modifies an existing qos request
> --
> 1.9.1
>

Re: [PATCH] power: qos: Export pm_qos_update_request_timeout()

[Hareesh Gundu]

On 12/5/2017 8:54 PM, Rafael J. Wysocki wrote:
> On Tue, Dec 5, 2017 at 11:45 AM, Hareesh Gundu <hareeshg@codeaurora.org> wrote:
>> Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout,
>> so that it can be usable from modules similar to the
>> pm_qos_update_request().
>>
>> Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
There is no in-tree kernel module using it. It's required for modules 
built out-tree kernel.
Does it really required show out tree kernel module uses this symbol ?
> I'd rather see a modular user of this along with the export.
>
>> ---
>>   kernel/power/qos.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
>> index 9d75039..3f501b4 100644
>> --- a/kernel/power/qos.c
>> +++ b/kernel/power/qos.c
>> @@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
>>
>>          schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
>>   }
>> +EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
>>
>>   /**
>>    * pm_qos_remove_request - modifies an existing qos request
>> --
>> 1.9.1
>>

Re: [PATCH] power: qos: Export pm_qos_update_request_timeout()

[Rafael J. Wysocki]

On Wed, Dec 6, 2017 at 4:35 PM, Hareesh Gundu <hareeshg@codeaurora.org> wrote:
>
> On 12/5/2017 8:54 PM, Rafael J. Wysocki wrote:
>>
>> On Tue, Dec 5, 2017 at 11:45 AM, Hareesh Gundu <hareeshg@codeaurora.org>
>> wrote:
>>>
>>> Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout,
>>> so that it can be usable from modules similar to the
>>> pm_qos_update_request().
>>>
>>> Signed-off-by: Hareesh Gundu <hareeshg@codeaurora.org>
>
> There is no in-tree kernel module using it. It's required for modules built
> out-tree kernel.
> Does it really required show out tree kernel module uses this symbol ?

If the module is out of the tree, the patch can be out of the tree
too, unless there is a very good reason for it to be in the tree.

So, what is that reason?