From: Lucas Stach <l.stach@pengutronix.de>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pm@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Angus Ainslie <angus@akkea.ca>,
linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support
Date: Tue, 16 Apr 2019 19:24:57 +0200 [thread overview]
Message-ID: <1555435497.2317.17.camel@pengutronix.de> (raw)
In-Reply-To: <20190413082748.29990-1-andrew.smirnov@gmail.com>
Series is:
Tested-by: Lucas Stach <l.stach@pengutronix.de>
Regards,
Lucas
Am Samstag, den 13.04.2019, 01:27 -0700 schrieb Andrey Smirnov:
> Everyone:
>
> This series contains patches adding support for HWMON integration, bug
> fixes and general improvements (hopefully) for TMU driver I made while
> working on it on i.MX8MQ.
>
> Feedback is welcome!
>
> Thanks,
> Andrey Smirnov
>
> Changes since [v3]
>
> - Series reabse on top of [rfc]
>
> - Fixed incorrect goto label in "thermal: qoriq: Pass data to
> qoriq_tmu_calibration()"
>
> - Added REGS_TRITSR() register description to "thermal: qoriq: Do
> not report invalid temperature reading"
>
> - Reworded commit message of "thermal: qoriq: Remove unnecessary
> DT node is NULL check"
>
> Changes since [v2]
>
> - Patches rebased on v5.1-rc1
>
> Changes since [v1]
>
> - Rebased on "linus" branch of
> git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git
> that included latest chagnes adding multi-sensors support
>
> - Dropped
>
> thermal: qoriq: Add support for multiple thremal sites
> thermal: qoriq: Be more strict when parsing
> thermal: qoriq: Simplify error handling in qoriq_tmu_get_sensor_id()
>
> since they are no longer relevant
>
> - Added
>
> thermal: qoriq: Don't store struct thermal_zone_device reference
> thermal: qoriq: Add local struct qoriq_sensor pointer
> thermal: qoriq: Embed per-sensor data into struct qoriq_tmu_data
> thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly
>
> to simplify latest codebase
>
> - Changed "thermal: qoriq: Do not report invalid temperature
> reading" to use regmap_read_poll_timeout() to make sure that
> tmu_get_temp() waits for fist sample to be ready before
> reporting it. This case is triggered on my setup if
> qoriq_thermal is compiled as a module
>
> [v1] lore.kernel.org/lkml/20190218191141.3729-1-andrew.smirnov@gmail.com
> [v2] lore.kernel.org/lkml/20190222200508.26325-1-andrew.smirnov@gmail.com
> [v3] lore.kernel.org/lkml/20190401041418.5999-1-andrew.smirnov@gmail.com
> [rfc] lore.kernel.org/lkml/20190404080647.8173-1-daniel.lezcano@linaro.org
>
> Andrey Smirnov (12):
> thermal: qoriq: Remove unnecessary DT node is NULL check
> thermal: qoriq: Add local struct device pointer
> thermal: qoriq: Don't store struct thermal_zone_device reference
> thermal: qoriq: Drop per-sensor data
> thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly
> thermal: qoriq: Pass data to qoriq_tmu_calibration() directly
> thermal: qoriq: Convert driver to use devm_ioremap()
> thermal: qoriq: Convert driver to use regmap API
> thermal: qoriq: Enable all sensors before registering them
> thermal: qoriq: Do not report invalid temperature reading
> thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs()
> thermal: qoriq: Add hwmon support
>
> drivers/thermal/qoriq_thermal.c | 287 +++++++++++++++-----------------
> drivers/thermal/thermal_hwmon.c | 28 ++++
> drivers/thermal/thermal_hwmon.h | 7 +
> 3 files changed, 171 insertions(+), 151 deletions(-)
>
next prev parent reply other threads:[~2019-04-16 17:24 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 8:27 [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 01/12] thermal: qoriq: Remove unnecessary DT node is NULL check Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 02/12] thermal: qoriq: Add local struct device pointer Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 03/12] thermal: qoriq: Don't store struct thermal_zone_device reference Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 04/12] thermal: qoriq: Drop per-sensor data Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 17:23 ` Daniel Lezcano
2019-04-16 17:23 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 05/12] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 06/12] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 16:51 ` Daniel Lezcano
2019-04-16 16:51 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 07/12] thermal: qoriq: Convert driver to use devm_ioremap() Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 16:52 ` Daniel Lezcano
2019-04-16 16:52 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 08/12] thermal: qoriq: Convert driver to use regmap API Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 16:58 ` Daniel Lezcano
2019-04-16 16:58 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 09/12] thermal: qoriq: Enable all sensors before registering them Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 17:09 ` Daniel Lezcano
2019-04-16 17:09 ` Daniel Lezcano
2019-04-18 20:02 ` Andrey Smirnov
2019-04-18 20:02 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 10/12] thermal: qoriq: Do not report invalid temperature reading Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 17:11 ` Daniel Lezcano
2019-04-16 17:11 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 11/12] thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs() Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 17:16 ` Daniel Lezcano
2019-04-16 17:16 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 12/12] thermal: qoriq: Add hwmon support Andrey Smirnov
2019-04-13 8:27 ` Andrey Smirnov
2019-04-16 17:17 ` Daniel Lezcano
2019-04-16 17:17 ` Daniel Lezcano
2019-04-16 17:24 ` Lucas Stach [this message]
2019-04-16 17:24 ` [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555435497.2317.17.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=cphealy@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox