Linux Power Management development
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: linux-pm@vger.kernel.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Chris Healy <cphealy@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Eduardo Valentin <edubezval@gmail.com>,
	Angus Ainslie <angus@akkea.ca>,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: [PATCH v4 01/12] thermal: qoriq: Remove unnecessary DT node is NULL check
Date: Sat, 13 Apr 2019 01:27:37 -0700	[thread overview]
Message-ID: <20190413082748.29990-2-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20190413082748.29990-1-andrew.smirnov@gmail.com>

It's impossible to use this driver outside of Device Tree, so if the
probe function is called, the dev.of_node is guaranteed to not be NULL
and guarding against that is pointless. Drop it.

Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Angus Ainslie (Purism) <angus@akkea.ca>
Cc: linux-imx@nxp.com
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/thermal/qoriq_thermal.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
index 405d1fbdd0cb..5828314ec74d 100644
--- a/drivers/thermal/qoriq_thermal.c
+++ b/drivers/thermal/qoriq_thermal.c
@@ -193,11 +193,6 @@ static int qoriq_tmu_probe(struct platform_device *pdev)
 	struct qoriq_tmu_data *data;
 	struct device_node *np = pdev->dev.of_node;
 
-	if (!np) {
-		dev_err(&pdev->dev, "Device OF-Node is NULL");
-		return -ENODEV;
-	}
-
 	data = devm_kzalloc(&pdev->dev, sizeof(struct qoriq_tmu_data),
 			    GFP_KERNEL);
 	if (!data)
-- 
2.20.1

  parent reply	other threads:[~2019-04-13  8:27 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-13  8:27 [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Andrey Smirnov
2019-04-13  8:27 ` Andrey Smirnov
2019-04-13  8:27 ` Andrey Smirnov [this message]
2019-04-13  8:27   ` [PATCH v4 01/12] thermal: qoriq: Remove unnecessary DT node is NULL check Andrey Smirnov
2019-04-13  8:27 ` [PATCH v4 02/12] thermal: qoriq: Add local struct device pointer Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-13  8:27 ` [PATCH v4 03/12] thermal: qoriq: Don't store struct thermal_zone_device reference Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-13  8:27 ` [PATCH v4 04/12] thermal: qoriq: Drop per-sensor data Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 17:23   ` Daniel Lezcano
2019-04-16 17:23     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 05/12] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-13  8:27 ` [PATCH v4 06/12] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 16:51   ` Daniel Lezcano
2019-04-16 16:51     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 07/12] thermal: qoriq: Convert driver to use devm_ioremap() Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 16:52   ` Daniel Lezcano
2019-04-16 16:52     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 08/12] thermal: qoriq: Convert driver to use regmap API Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 16:58   ` Daniel Lezcano
2019-04-16 16:58     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 09/12] thermal: qoriq: Enable all sensors before registering them Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 17:09   ` Daniel Lezcano
2019-04-16 17:09     ` Daniel Lezcano
2019-04-18 20:02     ` Andrey Smirnov
2019-04-18 20:02       ` Andrey Smirnov
2019-04-13  8:27 ` [PATCH v4 10/12] thermal: qoriq: Do not report invalid temperature reading Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 17:11   ` Daniel Lezcano
2019-04-16 17:11     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 11/12] thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs() Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 17:16   ` Daniel Lezcano
2019-04-16 17:16     ` Daniel Lezcano
2019-04-13  8:27 ` [PATCH v4 12/12] thermal: qoriq: Add hwmon support Andrey Smirnov
2019-04-13  8:27   ` Andrey Smirnov
2019-04-16 17:17   ` Daniel Lezcano
2019-04-16 17:17     ` Daniel Lezcano
2019-04-16 17:24 ` [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Lucas Stach
2019-04-16 17:24   ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190413082748.29990-2-andrew.smirnov@gmail.com \
    --to=andrew.smirnov@gmail.com \
    --cc=angus@akkea.ca \
    --cc=cphealy@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox