From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Amit Kucheria <amit.kucheria@linaro.org>,
Robin Randhawa <robin.randhawa@arm.com>,
linux-pm@vger.kernel.org, Liviu Dudau <Liviu.Dudau@arm.com>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
Steve Bannister <Steve.Bannister@arm.com>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Charles Garcia-Tobin <charles.garcia-tobin@arm.com>
Subject: Re: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu_get
Date: Fri, 22 Mar 2013 14:22:39 +0100 [thread overview]
Message-ID: <1557799.tbMLSpRn7J@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpokYkieTyv=e9kM=zp6qJ9o5+c1D7eodsHf2ncCUig-1MA@mail.gmail.com>
On Friday, March 22, 2013 05:40:25 PM Viresh Kumar wrote:
> On 22 March 2013 17:42, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > Which would be useful to write in the changelog, wouldn't it?
>
> Hmm..
>
> copy-paste with gmail is also broken, so find it attached too.
>
> New change log, no change in patch and you can trust me on that :)
OK, applied to bleeding-edge.
Thanks,
Rafael
> ----------x-------------x--------
>
> From 034e5ac4cccd09872592a46decd38d5f24047f10 Mon Sep 17 00:00:00 2001
> Message-Id: <034e5ac4cccd09872592a46decd38d5f24047f10.1363954124.git.viresh.kumar@linaro.org>
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Fri, 22 Mar 2013 15:15:48 +0530
> Subject: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to
> cpufreq_cpu_get
>
> In cpufreq_stats_free_sysfs() we aren't balancing calls to cpufreq_cpu_get()
> with cpufreq_cpu_put(). This will never let us have ref count to policy->kobj as
> zero.
>
> We will get a hang if somehow cpufreq_driver_unregister() is called. And that
> can happen when we compile our driver as module and insmod/rmmod it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-03-22 13:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 10:13 [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu_get Viresh Kumar
2013-03-22 11:12 ` Amit Kucheria
2013-03-22 11:17 ` Viresh Kumar
2013-03-22 11:47 ` Rafael J. Wysocki
2013-03-22 11:59 ` Rafael J. Wysocki
2013-03-22 11:55 ` Viresh Kumar
2013-03-22 11:59 ` Amit Kucheria
2013-03-22 12:12 ` Rafael J. Wysocki
2013-03-22 12:10 ` Viresh Kumar
2013-03-22 13:22 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557799.tbMLSpRn7J@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox