From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Amit Kucheria <amit.kucheria@linaro.org>,
Robin Randhawa <robin.randhawa@arm.com>,
linux-pm@vger.kernel.org, Liviu Dudau <Liviu.Dudau@arm.com>,
linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org,
Steve Bannister <Steve.Bannister@arm.com>,
Arvind Chauhan <arvind.chauhan@arm.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Charles Garcia-Tobin <charles.garcia-tobin@arm.com>
Subject: Re: [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu_get
Date: Fri, 22 Mar 2013 12:47:35 +0100 [thread overview]
Message-ID: <3472441.hhXSbXj7X9@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpo=bOcPLESk6p88gjHq=i-D8zFhhEL_4pgZUtjRYZnD_7w@mail.gmail.com>
On Friday, March 22, 2013 04:47:29 PM Viresh Kumar wrote:
> On 22 March 2013 16:42, Amit Kucheria <amit.kucheria@linaro.org> wrote:
> > On Fri, Mar 22, 2013 at 3:43 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >> In cpufreq_stats_free_sysfs() we aren't balancing calls to cpufreq_cpu_get()
> >> with cpufreq_cpu_put(). This will never let us have ref count to policy->kobj as
> >> zero.
> >
> > Rafael,
> >
> > Since this prevents booting on our hardware (we unregister and
> > re-register the cpufreq driver to account for virtual cores), will
> > this be considered as a hotfix for 3.9?
> >
> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > Acked-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> Sorry i forgot to mention, this should be pushed for next rc.
Well, -rc5 is a realistic target.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-03-22 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 10:13 [PATCH] cpufreq: stats: do cpufreq_cpu_put() corresponding to cpufreq_cpu_get Viresh Kumar
2013-03-22 11:12 ` Amit Kucheria
2013-03-22 11:17 ` Viresh Kumar
2013-03-22 11:47 ` Rafael J. Wysocki [this message]
2013-03-22 11:59 ` Rafael J. Wysocki
2013-03-22 11:55 ` Viresh Kumar
2013-03-22 11:59 ` Amit Kucheria
2013-03-22 12:12 ` Rafael J. Wysocki
2013-03-22 12:10 ` Viresh Kumar
2013-03-22 13:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3472441.hhXSbXj7X9@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Liviu.Dudau@arm.com \
--cc=Steve.Bannister@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=charles.garcia-tobin@arm.com \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robin.randhawa@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox