From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
WANG Chao <chao.wang@ucloud.cn>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Vikas Shivappa <vikas.shivappa@linux.intel.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Mathias Krause <minipli@googlemail.com>,
the arch/x86 maintainers <x86@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again
Date: Wed, 15 Nov 2017 01:06:37 +0100 [thread overview]
Message-ID: <1640278.1Q7Qv8A4h4@aspire.rjw.lan> (raw)
In-Reply-To: <alpine.DEB.2.20.1711150038120.2221@nanos>
On Wednesday, November 15, 2017 12:53:24 AM CET Thomas Gleixner wrote:
> On Tue, 14 Nov 2017, Linus Torvalds wrote:
>
> > On Tue, Nov 14, 2017 at 2:47 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > >
> > > So what about the one below? It works for me as expected.
> >
> > Can somebody with 100+ cores test this? Ingo? You had a 160 core
> > machine that took forever, didn't you..
>
> On a 144 CPUs machine:
>
> time cat /proc/cpuinfo >/dev/null
>
> Current head:
>
> real 0m0.003s
> user 0m0.000s
> sys 0m0.002s
>
> Current head + Raphaels patch:
>
> real 0m0.029s
> user 0m0.000s
> sys 0m0.010s
>
> So that patch is actually slower.
Thanks for testing!
It is adding a delay (mostly because it has to allow APERF and MPERF to grow
somewhat for the frequency computation to produce a useful result), so it will
be slower even in theory, but really the question is whether or not the slow
down is acceptable.
It doesn't look horrible to me, but that's my patch after all. :-)
next prev parent reply other threads:[~2017-11-15 0:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171109103814.70688-1-chao.wang@ucloud.cn>
2017-11-09 16:06 ` [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again Rafael J. Wysocki
2017-11-09 22:30 ` Rafael J. Wysocki
2017-11-10 0:06 ` Rafael J. Wysocki
2017-11-10 4:04 ` WANG Chao
2017-11-10 4:11 ` WANG Chao
2017-11-10 19:11 ` Linus Torvalds
2017-11-10 23:09 ` Rafael J. Wysocki
2017-11-14 22:47 ` Rafael J. Wysocki
2017-11-14 23:02 ` Linus Torvalds
2017-11-14 23:53 ` Thomas Gleixner
2017-11-15 0:04 ` Linus Torvalds
2017-11-15 0:06 ` Linus Torvalds
2017-11-15 0:30 ` Rafael J. Wysocki
2017-11-15 0:34 ` Linus Torvalds
2017-11-15 1:13 ` [PATCH] x86 / CPU: Always show current CPU frequency in /proc/cpuinfo Rafael J. Wysocki
2017-11-15 8:47 ` Thomas Gleixner
2017-11-15 9:33 ` WANG Chao
2017-11-16 0:24 ` Rafael J. Wysocki
2017-11-16 9:50 ` WANG Chao
2017-11-16 13:54 ` Rafael J. Wysocki
2017-11-17 4:27 ` WANG Chao
2017-11-17 13:33 ` Rafael J. Wysocki
2017-11-15 7:43 ` [PATCH] x86: use cpufreq_quick_get() for /proc/cpuinfo "cpu MHz" again Ingo Molnar
2017-11-15 7:54 ` Greg Kroah-Hartman
2017-11-15 17:27 ` Linus Torvalds
2017-11-15 18:05 ` Thomas Gleixner
2017-11-15 8:47 ` Thomas Gleixner
2017-11-15 0:06 ` Rafael J. Wysocki [this message]
2017-11-10 7:25 ` Ingo Molnar
2017-11-10 9:21 ` WANG Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1640278.1Q7Qv8A4h4@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=chao.wang@ucloud.cn \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=kstewart@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vikas.shivappa@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox