Linux Power Management development
 help / color / mirror / Atom feed
* [PATCH] power: supply: Fix maintenance charge table kernel-doc
@ 2026-09-09  6:46 Karl Mehltretter
  2026-09-09 22:51 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-09  6:46 UTC (permalink / raw)
  To: Sebastian Reichel; +Cc: Karl Mehltretter, Linus Walleij, linux-pm, linux-kernel

struct power_supply_maintenance_charge_table contains
charge_safety_timer_minutes, but its kernel-doc describes
safety_timer_minutes. This leaves the real member undescribed and adds a
nonexistent member to the generated documentation.

Use the member's actual name.

Fixes: d72ce7d32478 ("power: supply: ab8500: Standardize maintenance charging")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 include/linux/power_supply.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index e749d2189335..95d3bc42ea17 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -414,9 +414,9 @@ struct power_supply_vbat_ri_table {
  * @charge_voltage_max_uv: maintenance charging voltage that is usually a bit
  *   lower than the constant_charge_voltage_max_uv. We can apply this settings
  *   charge_current_max_ua until we get back up to this voltage.
- * @safety_timer_minutes: maintenance charging safety timer, with an expiry
- *   time in minutes. We will only use maintenance charging in this setting
- *   for a certain amount of time, then we will first move to the next
+ * @charge_safety_timer_minutes: maintenance charging safety timer, with an
+ *   expiry time in minutes. We will only use maintenance charging in this
+ *   setting for a certain amount of time, then we will first move to the next
  *   maintenance charge current and voltage pair in respective array and wait
  *   for the next safety timer timeout, or, if we reached the last maintencance
  *   charging setting, disable charging until we reach

base-commit: 893e11787f78e43b534e252249ac3fff4d1333f8
-- 
2.53.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: Fix maintenance charge table kernel-doc
  2026-09-09  6:46 [PATCH] power: supply: Fix maintenance charge table kernel-doc Karl Mehltretter
@ 2026-09-09 22:51 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2026-09-09 22:51 UTC (permalink / raw)
  To: Sebastian Reichel, Karl Mehltretter; +Cc: linux-pm, linux-kernel, Linus Walleij


On Wed, 09 Sep 2026 08:46:23 +0200, Karl Mehltretter wrote:
> struct power_supply_maintenance_charge_table contains
> charge_safety_timer_minutes, but its kernel-doc describes
> safety_timer_minutes. This leaves the real member undescribed and adds a
> nonexistent member to the generated documentation.
> 
> Use the member's actual name.
> 
> [...]

Applied, thanks!

[1/1] power: supply: Fix maintenance charge table kernel-doc
      commit: 45d4af4e80a25881b6b75e8e34872c555c43a41d

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-09 22:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09  6:46 [PATCH] power: supply: Fix maintenance charge table kernel-doc Karl Mehltretter
2026-09-09 22:51 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox