* [PATCH] PM: prevent runtime_resume from racing with probe [not found] <Pine.LNX.4.44L0.1107011045160.1988-100000@iolanthe.rowland.org> @ 2011-07-01 21:13 ` Alan Stern 2011-07-01 21:42 ` Rafael J. Wysocki 0 siblings, 1 reply; 2+ messages in thread From: Alan Stern @ 2011-07-01 21:13 UTC (permalink / raw) To: Rafael J. Wysocki; +Cc: Linux-pm mailing list This patch (as1475) adds device_lock() and device_unlock() calls to the store methods for the power/control and power/autosuspend_delay_ms sysfs attribute files. We don't want badly timed writes to these files to cause runtime_resume callbacks to occur while a driver is being probed for a device. Signed-off-by: Alan Stern <stern@rowland.harvard.edu> --- drivers/base/power/sysfs.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) Index: usb-3.0/drivers/base/power/sysfs.c =================================================================== --- usb-3.0.orig/drivers/base/power/sysfs.c +++ usb-3.0/drivers/base/power/sysfs.c @@ -116,12 +116,14 @@ static ssize_t control_store(struct devi cp = memchr(buf, '\n', n); if (cp) len = cp - buf; + device_lock(dev); if (len == sizeof ctrl_auto - 1 && strncmp(buf, ctrl_auto, len) == 0) pm_runtime_allow(dev); else if (len == sizeof ctrl_on - 1 && strncmp(buf, ctrl_on, len) == 0) pm_runtime_forbid(dev); else - return -EINVAL; + n = -EINVAL; + device_unlock(dev); return n; } @@ -205,7 +207,9 @@ static ssize_t autosuspend_delay_ms_stor if (strict_strtol(buf, 10, &delay) != 0 || delay != (int) delay) return -EINVAL; + device_lock(dev); pm_runtime_set_autosuspend_delay(dev, delay); + device_unlock(dev); return n; } ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM: prevent runtime_resume from racing with probe 2011-07-01 21:13 ` [PATCH] PM: prevent runtime_resume from racing with probe Alan Stern @ 2011-07-01 21:42 ` Rafael J. Wysocki 0 siblings, 0 replies; 2+ messages in thread From: Rafael J. Wysocki @ 2011-07-01 21:42 UTC (permalink / raw) To: Alan Stern; +Cc: Linux-pm mailing list On Friday, July 01, 2011, Alan Stern wrote: > This patch (as1475) adds device_lock() and device_unlock() calls to > the store methods for the power/control and power/autosuspend_delay_ms > sysfs attribute files. We don't want badly timed writes to these > files to cause runtime_resume callbacks to occur while a driver is > being probed for a device. > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu> Applied to suspend-2.6/linux-next. Thanks, Rafael > --- > > drivers/base/power/sysfs.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > Index: usb-3.0/drivers/base/power/sysfs.c > =================================================================== > --- usb-3.0.orig/drivers/base/power/sysfs.c > +++ usb-3.0/drivers/base/power/sysfs.c > @@ -116,12 +116,14 @@ static ssize_t control_store(struct devi > cp = memchr(buf, '\n', n); > if (cp) > len = cp - buf; > + device_lock(dev); > if (len == sizeof ctrl_auto - 1 && strncmp(buf, ctrl_auto, len) == 0) > pm_runtime_allow(dev); > else if (len == sizeof ctrl_on - 1 && strncmp(buf, ctrl_on, len) == 0) > pm_runtime_forbid(dev); > else > - return -EINVAL; > + n = -EINVAL; > + device_unlock(dev); > return n; > } > > @@ -205,7 +207,9 @@ static ssize_t autosuspend_delay_ms_stor > if (strict_strtol(buf, 10, &delay) != 0 || delay != (int) delay) > return -EINVAL; > > + device_lock(dev); > pm_runtime_set_autosuspend_delay(dev, delay); > + device_unlock(dev); > return n; > } > > > > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-01 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.44L0.1107011045160.1988-100000@iolanthe.rowland.org>
2011-07-01 21:13 ` [PATCH] PM: prevent runtime_resume from racing with probe Alan Stern
2011-07-01 21:42 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox