* [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call()
@ 2014-02-17 16:09 Nicolas Pitre
2014-02-21 21:44 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Pitre @ 2014-02-17 16:09 UTC (permalink / raw)
To: Paul Burton; +Cc: Rafael J. Wysocki, Daniel Lezcano, linux-pm, linux-mips
The core idle loop now takes care of it.
Signed-off-by: Nicolas Pitre <nico@linaro.org>
---
I noticed commit c0b5d598aefda in linux-next adds a call to
cpuidle_idle_call(). At the same time we're rationalizing the idle
handling code in order to integrate it with the scheduler proper.
Please note that a similar patch to the one below will be necessary once
everything gets merged together.
diff --git a/arch/mips/kernel/idle.c b/arch/mips/kernel/idle.c
index 4b1554b3f5..2d753de5dc 100644
--- a/arch/mips/kernel/idle.c
+++ b/arch/mips/kernel/idle.c
@@ -253,8 +253,7 @@ static void mips_cpu_idle(void)
void arch_cpu_idle(void)
{
- if (cpuidle_idle_call())
- mips_cpu_idle();
+ mips_cpu_idle();
}
#ifdef CONFIG_CPU_IDLE
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call()
2014-02-17 16:09 [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call() Nicolas Pitre
@ 2014-02-21 21:44 ` Ralf Baechle
2014-02-21 22:27 ` Nicolas Pitre
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2014-02-21 21:44 UTC (permalink / raw)
To: Nicolas Pitre
Cc: Paul Burton, Rafael J. Wysocki, Daniel Lezcano, linux-pm,
linux-mips
On Mon, Feb 17, 2014 at 11:09:45AM -0500, Nicolas Pitre wrote:
> I noticed commit c0b5d598aefda in linux-next adds a call to
> cpuidle_idle_call(). At the same time we're rationalizing the idle
> handling code in order to integrate it with the scheduler proper.
> Please note that a similar patch to the one below will be necessary once
> everything gets merged together.
So how shall we merge this patch, shall I fold it into c0b5d598aefda or?
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call()
2014-02-21 21:44 ` Ralf Baechle
@ 2014-02-21 22:27 ` Nicolas Pitre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Pitre @ 2014-02-21 22:27 UTC (permalink / raw)
To: Ralf Baechle
Cc: Paul Burton, Rafael J. Wysocki, Daniel Lezcano, linux-pm,
linux-mips
On Fri, 21 Feb 2014, Ralf Baechle wrote:
> On Mon, Feb 17, 2014 at 11:09:45AM -0500, Nicolas Pitre wrote:
>
> > I noticed commit c0b5d598aefda in linux-next adds a call to
> > cpuidle_idle_call(). At the same time we're rationalizing the idle
> > handling code in order to integrate it with the scheduler proper.
> > Please note that a similar patch to the one below will be necessary once
> > everything gets merged together.
>
> So how shall we merge this patch, shall I fold it into c0b5d598aefda or?
Merging it on your side is probably the best option. There would be a
window in mainline during which the callback registered with cpuidle
won't be invoked, but that is not worse than the v3.13 behavior.
Nicolas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-21 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-17 16:09 [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-02-21 21:44 ` Ralf Baechle
2014-02-21 22:27 ` Nicolas Pitre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox