* [PATCH -next] ipaq_micro_battery: fix sparse non static symbol warning
@ 2014-07-28 13:14 weiyj_lk
2014-07-28 13:39 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-07-28 13:14 UTC (permalink / raw)
To: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse
Cc: Wei Yongjun, linux-pm
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fixes the following sparse warnings:
drivers/power/ipaq_micro_battery.c:278:24: warning:
symbol 'micro_batt_device_driver' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/power/ipaq_micro_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/ipaq_micro_battery.c b/drivers/power/ipaq_micro_battery.c
index 54632ea..9d69460 100644
--- a/drivers/power/ipaq_micro_battery.c
+++ b/drivers/power/ipaq_micro_battery.c
@@ -275,7 +275,7 @@ static const struct dev_pm_ops micro_batt_dev_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(micro_batt_suspend, micro_batt_resume)
};
-struct platform_driver micro_batt_device_driver = {
+static struct platform_driver micro_batt_device_driver = {
.driver = {
.name = "ipaq-micro-battery",
.pm = µ_batt_dev_pm_ops,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] ipaq_micro_battery: fix sparse non static symbol warning
2014-07-28 13:14 [PATCH -next] ipaq_micro_battery: fix sparse non static symbol warning weiyj_lk
@ 2014-07-28 13:39 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2014-07-28 13:39 UTC (permalink / raw)
To: weiyj_lk; +Cc: Dmitry Eremin-Solenikov, David Woodhouse, Wei Yongjun, linux-pm
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
Hi,
On Mon, Jul 28, 2014 at 09:14:21PM +0800, weiyj_lk@163.com wrote:
> Fixes the following sparse warnings:
>
> drivers/power/ipaq_micro_battery.c:278:24: warning:
> symbol 'micro_batt_device_driver' was not declared. Should it be static?
thanks, pulled into battery-2.6.git:
http://git.infradead.org/battery-2.6.git/commit/5e37195f30cc31e6a1052cbc282254e127c1b8c7
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-28 13:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-28 13:14 [PATCH -next] ipaq_micro_battery: fix sparse non static symbol warning weiyj_lk
2014-07-28 13:39 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox