* [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id
@ 2015-12-23 10:37 Andrzej Hajda
2015-12-23 10:41 ` Viresh Kumar
2015-12-23 10:48 ` Sudeep Holla
0 siblings, 2 replies; 3+ messages in thread
From: Andrzej Hajda @ 2015-12-23 10:37 UTC (permalink / raw)
To: Sudeep Holla
Cc: Andrzej Hajda, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Rafael J. Wysocki, Viresh Kumar,
open list:SYSTEM CONTROL & POWER INTERFACE SCPI Message...,
open list:CPU FREQUENCY DRIVERS, open list
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/cpufreq/scpi-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16f..de5e89b 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
- u8 domain = topology_physical_package_id(cpu_dev->id);
+ int domain = topology_physical_package_id(cpu_dev->id);
if (domain < 0)
return ERR_PTR(-EINVAL);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id
2015-12-23 10:37 [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Andrzej Hajda
@ 2015-12-23 10:41 ` Viresh Kumar
2015-12-23 10:48 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2015-12-23 10:41 UTC (permalink / raw)
To: Andrzej Hajda
Cc: Sudeep Holla, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Rafael J. Wysocki,
open list:SYSTEM CONTROL & POWER INTERFACE (SCPI) Message...,
open list:CPU FREQUENCY DRIVERS, open list
On 23-12-15, 11:37, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/cpufreq/scpi-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index 2c3b16f..de5e89b 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
>
> static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
> {
> - u8 domain = topology_physical_package_id(cpu_dev->id);
> + int domain = topology_physical_package_id(cpu_dev->id);
>
> if (domain < 0)
> return ERR_PTR(-EINVAL);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id
2015-12-23 10:37 [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Andrzej Hajda
2015-12-23 10:41 ` Viresh Kumar
@ 2015-12-23 10:48 ` Sudeep Holla
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2015-12-23 10:48 UTC (permalink / raw)
To: Andrzej Hajda, Rafael J. Wysocki
Cc: Sudeep Holla, Bartlomiej Zolnierkiewicz, Marek Szyprowski,
Viresh Kumar,
open list:SYSTEM CONTROL & POWER INTERFACE (SCPI) Message...,
open list:CPU FREQUENCY DRIVERS, open list
On 23/12/15 10:37, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
There has a patch posted by Dan Carpenter [1] which I reposted[2],
but it again slipped through the cracks. I will poke Rafael again on that.
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380292.html
[2] https://lkml.org/lkml/2015/12/15/219
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-23 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-23 10:37 [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Andrzej Hajda
2015-12-23 10:41 ` Viresh Kumar
2015-12-23 10:48 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox