From: Viresh Kumar <viresh.kumar@linaro.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support
Date: Tue, 1 Mar 2016 07:46:52 +0530 [thread overview]
Message-ID: <20160301021652.GW2791@vireshk-i7> (raw)
In-Reply-To: <1456765892.21069.18.camel@linux.intel.com>
On 29-02-16, 09:11, Srinivas Pandruvada wrote:
> This depends on ACPI configuration, so not guaranteed to have one cpu
> per policy. Since this is not guaranteed, I can't change mode to Read
> only on some as after I set the cpufreq_driver->attr, the other call to
> init may change the mode before the actual attribute creation.
> So safe bet is to implement like boost for all CPUs and fail on read
> for some CPUs, where this is not present. If this becomes a problem,
> then we can revisit.
Perhaps don't look at it on per-cpu basis, but rather per-policy basis
(as the files are going to be shared).
So, maybe just create the attribute always and return errors by
default. Once ->init() is called and you know if a CPU supports it or
not, toggle some internal flag to allow read/write to those sysfs
files.
--
viresh
next prev parent reply other threads:[~2016-03-01 2:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 22:25 [PATCH] cpufreq: acpi_cpufreq: base frequency attribute support Srinivas Pandruvada
2015-10-07 17:23 ` Viresh Kumar
2015-10-09 15:34 ` Srinivas Pandruvada
2015-10-15 22:45 ` Rafael J. Wysocki
2015-10-16 5:42 ` Viresh Kumar
2016-02-24 20:00 ` Srinivas Pandruvada
2016-02-24 20:05 ` Rafael J. Wysocki
2016-02-24 23:37 ` Srinivas Pandruvada
2016-02-25 3:27 ` Viresh Kumar
2016-02-25 18:07 ` Srinivas Pandruvada
2016-02-26 1:10 ` Pandruvada, Srinivas
2016-02-26 1:57 ` Viresh Kumar
2016-02-26 20:21 ` Srinivas Pandruvada
2016-02-29 3:16 ` Viresh Kumar
2016-02-29 17:11 ` Srinivas Pandruvada
2016-03-01 2:16 ` Viresh Kumar [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-02-29 20:36 Srinivas Pandruvada
2016-03-01 2:28 ` Viresh Kumar
2016-03-01 18:10 ` Srinivas Pandruvada
2016-03-02 2:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301021652.GW2791@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox