* [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver
@ 2016-05-16 11:07 Pankaj Gupta (Pankaj Gupta)
2016-05-16 11:10 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Pankaj Gupta (Pankaj Gupta) @ 2016-05-16 11:07 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Saravana Kannan, Yinghai Lu
simplified goto out in cpufreq_register_driver for increasing
code readability
Signed-off-by: Pankaj Gupta <pankaj.gupta@spreadtrum.com>
Signed-off-by: Sanjeev Yadav <sanjeev.yadav@spreadtrum.com>
---
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index b87596b..0bc23f6 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -2370,10 +2370,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
register_hotcpu_notifier(&cpufreq_cpu_notifier);
pr_debug("driver %s up and running\n", driver_data->name);
-
-out:
- put_online_cpus();
- return ret;
+ goto out;
err_if_unreg:
subsys_interface_unregister(&cpufreq_interface);
@@ -2383,7 +2380,9 @@ err_null_driver:
write_lock_irqsave(&cpufreq_driver_lock, flags);
cpufreq_driver = NULL;
write_unlock_irqrestore(&cpufreq_driver_lock, flags);
- goto out;
+out:
+ put_online_cpus();
+ return ret;
}
EXPORT_SYMBOL_GPL(cpufreq_register_driver);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver
2016-05-16 11:07 [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver Pankaj Gupta (Pankaj Gupta)
@ 2016-05-16 11:10 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2016-05-16 11:10 UTC (permalink / raw)
To: Pankaj Gupta (Pankaj Gupta)
Cc: Rafael J. Wysocki, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Saravana Kannan, Yinghai Lu
On 16-05-16, 11:07, Pankaj Gupta (Pankaj Gupta) wrote:
> simplified goto out in cpufreq_register_driver for increasing
> code readability
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@spreadtrum.com>
> Signed-off-by: Sanjeev Yadav <sanjeev.yadav@spreadtrum.com>
> ---
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index b87596b..0bc23f6 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2370,10 +2370,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
>
> register_hotcpu_notifier(&cpufreq_cpu_notifier);
> pr_debug("driver %s up and running\n", driver_data->name);
> -
> -out:
> - put_online_cpus();
> - return ret;
> + goto out;
>
> err_if_unreg:
> subsys_interface_unregister(&cpufreq_interface);
> @@ -2383,7 +2380,9 @@ err_null_driver:
> write_lock_irqsave(&cpufreq_driver_lock, flags);
> cpufreq_driver = NULL;
> write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> - goto out;
> +out:
> + put_online_cpus();
> + return ret;
> }
> EXPORT_SYMBOL_GPL(cpufreq_register_driver);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-16 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-16 11:07 [PATCH] driver: cpufreq: simplified goto out in cpufreq_register_driver Pankaj Gupta (Pankaj Gupta)
2016-05-16 11:10 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox