Linux Power Management development
 help / color / mirror / Atom feed
* [PATCH 0/2] power: supply: Fix module autoload for some platform drivers
@ 2016-10-17 19:13 Javier Martinez Canillas
  2016-10-17 19:13 ` [PATCH 1/2] power: supply: max8997_charger: Fix module autoload Javier Martinez Canillas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, Sebastian Reichel, Chen-Yu Tsai,
	linux-pm

Hello Sebastian,

I noticed that module autoload won't be working for some of the power
supply platform drivers. This patch series contains fixes for these.

Best regards,
Javier


Javier Martinez Canillas (2):
  power: supply: max8997_charger: Fix module autoload
  power: supply: axp288_fuel_gauge: Fix module autoload

 drivers/power/supply/axp288_fuel_gauge.c | 1 +
 drivers/power/supply/max8997_charger.c   | 1 +
 2 files changed, 2 insertions(+)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] power: supply: max8997_charger: Fix module autoload
  2016-10-17 19:13 [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Javier Martinez Canillas
@ 2016-10-17 19:13 ` Javier Martinez Canillas
  2016-10-17 19:13 ` [PATCH 2/2] power: supply: axp288_fuel_gauge: " Javier Martinez Canillas
  2016-10-19  3:34 ` [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Sebastian Reichel
  2 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:13 UTC (permalink / raw)
  To: linux-kernel; +Cc: Javier Martinez Canillas, Sebastian Reichel, linux-pm

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/power/supply/max8997_charger.ko | grep alias
$

After this patch:

$ modinfo drivers/power/supply/max8997_charger.ko | grep alias
alias:          platform:max8997-battery

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/power/supply/max8997_charger.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/max8997_charger.c b/drivers/power/supply/max8997_charger.c
index 0b2eab571528..290ddc12b040 100644
--- a/drivers/power/supply/max8997_charger.c
+++ b/drivers/power/supply/max8997_charger.c
@@ -184,6 +184,7 @@ static const struct platform_device_id max8997_battery_id[] = {
 	{ "max8997-battery", 0 },
 	{ }
 };
+MODULE_DEVICE_TABLE(platform, max8997_battery_id);
 
 static struct platform_driver max8997_battery_driver = {
 	.driver = {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] power: supply: axp288_fuel_gauge: Fix module autoload
  2016-10-17 19:13 [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Javier Martinez Canillas
  2016-10-17 19:13 ` [PATCH 1/2] power: supply: max8997_charger: Fix module autoload Javier Martinez Canillas
@ 2016-10-17 19:13 ` Javier Martinez Canillas
  2016-10-19  3:34 ` [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Sebastian Reichel
  2 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:13 UTC (permalink / raw)
  To: linux-kernel
  Cc: Javier Martinez Canillas, Sebastian Reichel, Chen-Yu Tsai,
	linux-pm

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/power/supply/axp288_fuel_gauge.ko | grep alias
$

After this patch:

$ modinfo drivers/power/supply/axp288_fuel_gauge.ko | grep alias
alias:          platform:axp288_fuel_gauge

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---

 drivers/power/supply/axp288_fuel_gauge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
index 5bdde692f724..539eb41504bb 100644
--- a/drivers/power/supply/axp288_fuel_gauge.c
+++ b/drivers/power/supply/axp288_fuel_gauge.c
@@ -1120,6 +1120,7 @@ static const struct platform_device_id axp288_fg_id_table[] = {
 	{ .name = DEV_NAME },
 	{},
 };
+MODULE_DEVICE_TABLE(platform, axp288_fg_id_table);
 
 static int axp288_fuel_gauge_remove(struct platform_device *pdev)
 {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] power: supply: Fix module autoload for some platform drivers
  2016-10-17 19:13 [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Javier Martinez Canillas
  2016-10-17 19:13 ` [PATCH 1/2] power: supply: max8997_charger: Fix module autoload Javier Martinez Canillas
  2016-10-17 19:13 ` [PATCH 2/2] power: supply: axp288_fuel_gauge: " Javier Martinez Canillas
@ 2016-10-19  3:34 ` Sebastian Reichel
  2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2016-10-19  3:34 UTC (permalink / raw)
  To: Javier Martinez Canillas; +Cc: linux-kernel, Chen-Yu Tsai, linux-pm

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

Hi Javier,

On Mon, Oct 17, 2016 at 04:13:34PM -0300, Javier Martinez Canillas wrote:
> Hello Sebastian,
> 
> I noticed that module autoload won't be working for some of the power
> supply platform drivers. This patch series contains fixes for these.
> 
> Best regards,
> Javier
> 
> 
> Javier Martinez Canillas (2):
>   power: supply: max8997_charger: Fix module autoload
>   power: supply: axp288_fuel_gauge: Fix module autoload
> 
>  drivers/power/supply/axp288_fuel_gauge.c | 1 +
>  drivers/power/supply/max8997_charger.c   | 1 +
>  2 files changed, 2 insertions(+)

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-10-19  3:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 19:13 [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Javier Martinez Canillas
2016-10-17 19:13 ` [PATCH 1/2] power: supply: max8997_charger: Fix module autoload Javier Martinez Canillas
2016-10-17 19:13 ` [PATCH 2/2] power: supply: axp288_fuel_gauge: " Javier Martinez Canillas
2016-10-19  3:34 ` [PATCH 0/2] power: supply: Fix module autoload for some platform drivers Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox