From: Sebastian Reichel <sre@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520
Date: Thu, 24 Nov 2016 00:08:33 +0100 [thread overview]
Message-ID: <20161123230832.anbbhmllij4bxpsh@earth> (raw)
In-Reply-To: <20161104183313.2767-1-afd@ti.com>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
Hi,
On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote:
> The BQ27510 and BQ27520 use a slightly different register map than the
> BQ27500, add a new type enum and add these gauges to it.
>
> Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional bq27xxx family devices")
> Based-on-patch-by: Kenneth R. Crudup <kenny@panix.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 41 +++++++++++++++++++++++++++++-
> drivers/power/supply/bq27xxx_battery_i2c.c | 4 +--
> include/linux/power/bq27xxx_battery.h | 3 ++-
> 3 files changed, 44 insertions(+), 4 deletions(-)
Queued into for-next. I think pali's hint, that bq27xxx_battery_overtemp()
should be implemented using a switch-case is valid to make the code more
readable. Please provide this change as follow-up patch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-11-23 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 18:33 [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520 Andrew F. Davis
2016-11-05 17:36 ` Pali Rohár
2016-11-23 23:08 ` Sebastian Reichel [this message]
2016-11-28 17:13 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123230832.anbbhmllij4bxpsh@earth \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox