From: Sebastian Reichel <sre@kernel.org>
To: Liam Breck <liam@networkimprov.net>
Cc: linux-pm@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
"Mark A . Greer" <mgreer@animalcreek.com>,
Liam Breck <kernel@networkimprov.net>,
Matt Ranostay <matt@ranostay.consulting>
Subject: Re: [PATCH v2 0/6] BQ24190 charger fixes
Date: Tue, 17 Jan 2017 01:25:35 +0100 [thread overview]
Message-ID: <20170117002534.nbvtq2s347biuaci@earth> (raw)
In-Reply-To: <CAKvHMgTZsiALaWqgwO0NjACi_smHtPUomd6PnbW-TQfG8jnFkQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
Hi Liam,
On Sun, Jan 15, 2017 at 10:05:26PM -0800, Liam Breck wrote:
> Changes in v2:
>
> #1 reorders: Fix irq triggering to IRQF_TRIGGER_FALLING
> #2 factors out part of: Call power_supply_changed() only for relevant component
> #3 replaces: Call enable_irq() only at the end of probe()
> #4 reorders: Call power_supply_changed() only for relevant component
> #5 unscrambles: Don't read fault register outside irq_handle_thread()
> #6 factors out part of: Don't read fault register outside irq_handle_thread()
>
> These are dropped; Tony will resubmit them in new patchset:
> Check the interrupt status on resume
> Use PM runtime autosuspend
I have no additional review comments to the ones you already
received. When you resend the patch series with Mark's comments
fixed, please don't forget to add the Acks to your patches.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-01-17 0:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 6:05 [PATCH v2 0/6] BQ24190 charger fixes Liam Breck
2017-01-16 17:21 ` Tony Lindgren
2017-01-16 17:30 ` Mark Greer
2017-01-16 17:45 ` Mark Greer
2017-01-16 19:42 ` Liam Breck
2017-01-17 1:50 ` Mark Greer
2017-01-17 0:25 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117002534.nbvtq2s347biuaci@earth \
--to=sre@kernel.org \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mgreer@animalcreek.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox