Re: [PATCH v3 0/6] BQ24190 charger fixes

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]

Hi,

On Mon, Jan 16, 2017 at 10:01:34PM -0800, Liam Breck wrote:
> On Mon, Jan 16, 2017 at 7:26 PM, Sebastian Reichel <sre@kernel.org> wrote:
> > On Mon, Jan 16, 2017 at 06:28:28PM -0800, Liam Breck wrote:
> >> These are misc fixes, tested on a custom OMAP3 board.
> >>
> >> Changes in v3
> >>
> >> #1 fixes figure ID to 37
> >> #5 fixes line over 80 chars
> >> #* adds Acked-by Tony & Mark
> >
> > You forgot to fix the whitespace issues Mark mentioned, also
> > please use "git send-mail" or make sure, that your patchset
> > is threaded (patch 1-6 are replies to "patch" 0) and the
> > actual patch is inline and can be applied using "git am"
> > (which currently complains).
> 
> Hi, would you accept the v3 patches as-is were I the module
> maintainer? Because I am the de facto maintainer :-)
> 
> I contracted Mark to write this driver, and he hasn't had hardware on
> which to test it for a few years...

So I mentioned three issues:

- Mail Threading
  Please *always* do this on kernel mailinglists. Otherwise
  other unrelated patches might be in between your patch series.

- MIME Patches
  Your patches do not apply. See also Section 6 in
  in Documentation/process/submitting-patches.rst

- Whitespace Issue
  If you do style changes, do them in a separate patch. If you
  move this new patch to the end of the series, I can apply the
  other ones directly.
  
-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]