From: Viresh Kumar <viresh.kumar@linaro.org>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Len Brown <lenb@kernel.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
linux-kernel@vger.kernel.org, smuckle.linux@gmail.com,
juri.lelli@arm.com, Morten.Rasmussen@arm.com,
patrick.bellasi@arm.com, eas-dev@lists.linaro.org
Subject: Re: [PATCH V2 3/4] intel_pstate: Ignore scheduler cpufreq callbacks on remote CPUs
Date: Fri, 30 Jun 2017 08:57:41 +0530 [thread overview]
Message-ID: <20170630032741.GT29665@vireshk-i7> (raw)
In-Reply-To: <1498771438.7952.118.camel@linux.intel.com>
On 29-06-17, 14:23, Srinivas Pandruvada wrote:
> On Thu, 2017-06-29 at 10:56 +0530, Viresh Kumar wrote:
> > From: Steve Muckle <smuckle.linux@gmail.com>
> >
> > In preparation for the scheduler cpufreq callback happening on remote
> > CPUs, check for this case in intel_pstate which currently requires
> > the
> > callback run on the local CPU. Such callbacks are ignored for now.
> Is it possible that we miss a chance to calculate load periodically at
> a predefined interval (10ms default), because the callback happened on
> a different CPU?
We aren't updating cpu->sample.time for remote callbacks here, so no
we shouldn't miss anything.
--
viresh
next prev parent reply other threads:[~2017-06-30 3:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 5:26 [PATCH V2 0/4] sched: cpufreq: Allow remote callbacks Viresh Kumar
2017-06-29 5:26 ` [PATCH V2 1/4] cpufreq: schedutil: Process remote callback for shared policies Viresh Kumar
2017-06-29 5:26 ` [PATCH V2 2/4] cpufreq: governor: " Viresh Kumar
2017-06-29 5:26 ` [PATCH V2 3/4] intel_pstate: Ignore scheduler cpufreq callbacks on remote CPUs Viresh Kumar
2017-06-29 21:23 ` Srinivas Pandruvada
2017-06-30 3:27 ` Viresh Kumar [this message]
2017-07-12 23:27 ` Rafael J. Wysocki
2017-06-29 5:26 ` [PATCH V2 4/4] sched: cpufreq: Enable remote sched cpufreq callbacks Viresh Kumar
2017-06-29 20:30 ` [PATCH V2 0/4] sched: cpufreq: Allow remote callbacks Rafael J. Wysocki
2017-06-30 3:24 ` Viresh Kumar
2017-07-12 23:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630032741.GT29665@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Morten.Rasmussen@arm.com \
--cc=eas-dev@lists.linaro.org \
--cc=juri.lelli@arm.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=smuckle.linux@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox