* [PATCH] cpufreq: intel_pstate: constify attribute_group structures.
@ 2017-07-03 8:10 Arvind Yadav
2017-07-03 9:00 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-07-03 8:10 UTC (permalink / raw)
To: srinivas.pandruvada, lenb, rjw, rafael.j.wysocki, viresh.kumar
Cc: linux-pm, linux-kernel
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
15197 2552 40 17789 457d drivers/cpufreq/intel_pstate.o
File size After adding 'const':
text data bss dec hex filename
15261 2488 40 17789 457d drivers/cpufreq/intel_pstate.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index b7de5bd..4323f94 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b,
NULL
};
-static struct attribute_group intel_pstate_attr_group = {
+static const struct attribute_group intel_pstate_attr_group = {
.attrs = intel_pstate_attributes,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] cpufreq: intel_pstate: constify attribute_group structures.
2017-07-03 8:10 [PATCH] cpufreq: intel_pstate: constify attribute_group structures Arvind Yadav
@ 2017-07-03 9:00 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2017-07-03 9:00 UTC (permalink / raw)
To: Arvind Yadav
Cc: srinivas.pandruvada, lenb, rjw, rafael.j.wysocki, linux-pm,
linux-kernel
On 03-07-17, 13:40, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 15197 2552 40 17789 457d drivers/cpufreq/intel_pstate.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 15261 2488 40 17789 457d drivers/cpufreq/intel_pstate.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index b7de5bd..4323f94 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1212,7 +1212,7 @@ static ssize_t store_min_perf_pct(struct kobject *a, struct attribute *b,
> NULL
> };
>
> -static struct attribute_group intel_pstate_attr_group = {
> +static const struct attribute_group intel_pstate_attr_group = {
> .attrs = intel_pstate_attributes,
> };
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-03 9:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-03 8:10 [PATCH] cpufreq: intel_pstate: constify attribute_group structures Arvind Yadav
2017-07-03 9:00 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox