From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Dave Gerlach <d-gerlach@ti.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Linux PM <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static
Date: Thu, 21 Dec 2017 11:17:50 +0530 [thread overview]
Message-ID: <20171221054750.GA19815@vireshk-i7> (raw)
In-Reply-To: <CAJZ5v0jNBhGzvmSShK=42SoD1Q0V2CZYfxRUv9SSV6nw2sozYw@mail.gmail.com>
On 21-12-17, 02:19, Rafael J. Wysocki wrote:
> On Wed, Dec 20, 2017 at 6:42 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > +Dave/Rafael,
> >
> > On 20-12-17, 05:44, Wei Yongjun wrote:
> >> Fixes the following sparse warning:
> >>
> >> drivers/opp/ti-opp-supply.c:276:5: warning:
> >> symbol 'ti_opp_supply_set_opp' was not declared. Should it be static?
> >>
> >> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> >> ---
> >> drivers/opp/ti-opp-supply.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/opp/ti-opp-supply.c b/drivers/opp/ti-opp-supply.c
> >> index 44dae3e..370eff3 100644
> >> --- a/drivers/opp/ti-opp-supply.c
> >> +++ b/drivers/opp/ti-opp-supply.c
> >> @@ -273,7 +273,7 @@ static int _opp_set_voltage(struct device *dev,
> >> *
> >> * Return: If successful, 0, else appropriate error value.
> >> */
> >> -int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >> +static int ti_opp_supply_set_opp(struct dev_pm_set_opp_data *data)
> >> {
> >> struct dev_pm_opp_supply *old_supply_vdd = &data->old_opp.supplies[0];
> >> struct dev_pm_opp_supply *old_supply_vbb = &data->old_opp.supplies[1];
> >
> > Maybe this should be folded to the original patch ?
>
> That is against the latest series from Dave, right?
>
> I can apply it.
Yes.
--
viresh
prev parent reply other threads:[~2017-12-21 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 5:44 [PATCH -next] PM / OPP: Make local function ti_opp_supply_set_opp() static Wei Yongjun
2017-12-20 5:42 ` Viresh Kumar
2017-12-21 1:19 ` Rafael J. Wysocki
2017-12-21 5:47 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221054750.GA19815@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=d-gerlach@ti.com \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vireshk@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox