* [PATCH] thermal: st: fix Makefile typo
@ 2018-12-10 21:57 Arnd Bergmann
2018-12-10 22:01 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2018-12-10 21:57 UTC (permalink / raw)
To: Zhang Rui, Eduardo Valentin, Arnd Bergmann,
David HERNANDEZ SANCHEZ
Cc: Daniel Lezcano, linux-pm, linux-kernel
When STM32_THERMAL is enabled, this overrides all previously
enabled files in the same directory, as seen from this link failure:
ERROR: "st_thermal_pm_ops" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
ERROR: "st_thermal_register" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
ERROR: "st_thermal_unregister" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
The correct syntax in Makefile requires using += instead of :=.
Fixes: 1d6931556073 ("thermal: add stm32 thermal driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/thermal/st/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/st/Makefile b/drivers/thermal/st/Makefile
index b2b9e9b96296..243ca7881b12 100644
--- a/drivers/thermal/st/Makefile
+++ b/drivers/thermal/st/Makefile
@@ -1,4 +1,4 @@
obj-$(CONFIG_ST_THERMAL) := st_thermal.o
obj-$(CONFIG_ST_THERMAL_SYSCFG) += st_thermal_syscfg.o
obj-$(CONFIG_ST_THERMAL_MEMMAP) += st_thermal_memmap.o
-obj-$(CONFIG_STM32_THERMAL) := stm_thermal.o
\ No newline at end of file
+obj-$(CONFIG_STM32_THERMAL) += stm_thermal.o
--
2.20.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: st: fix Makefile typo
2018-12-10 21:57 [PATCH] thermal: st: fix Makefile typo Arnd Bergmann
@ 2018-12-10 22:01 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2018-12-10 22:01 UTC (permalink / raw)
To: Arnd Bergmann, Zhang Rui, Eduardo Valentin,
David HERNANDEZ SANCHEZ
Cc: linux-pm, linux-kernel
On 10/12/2018 22:57, Arnd Bergmann wrote:
> When STM32_THERMAL is enabled, this overrides all previously
> enabled files in the same directory, as seen from this link failure:
>
> ERROR: "st_thermal_pm_ops" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
> ERROR: "st_thermal_register" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
> ERROR: "st_thermal_unregister" [drivers/thermal/st/st_thermal_syscfg.ko] undefined!
>
> The correct syntax in Makefile requires using += instead of :=.
>
> Fixes: 1d6931556073 ("thermal: add stm32 thermal driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> drivers/thermal/st/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/st/Makefile b/drivers/thermal/st/Makefile
> index b2b9e9b96296..243ca7881b12 100644
> --- a/drivers/thermal/st/Makefile
> +++ b/drivers/thermal/st/Makefile
> @@ -1,4 +1,4 @@
> obj-$(CONFIG_ST_THERMAL) := st_thermal.o
> obj-$(CONFIG_ST_THERMAL_SYSCFG) += st_thermal_syscfg.o
> obj-$(CONFIG_ST_THERMAL_MEMMAP) += st_thermal_memmap.o
> -obj-$(CONFIG_STM32_THERMAL) := stm_thermal.o
> \ No newline at end of file
> +obj-$(CONFIG_STM32_THERMAL) += stm_thermal.o
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-10 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 21:57 [PATCH] thermal: st: fix Makefile typo Arnd Bergmann
2018-12-10 22:01 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox