From: Peter Zijlstra <peterz@infradead.org>
To: Len Brown <lenb@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>, Len Brown <len.brown@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 07/14] powercap/intel_rapl: Simplify rapl_find_package()
Date: Tue, 26 Feb 2019 20:06:58 +0100 [thread overview]
Message-ID: <20190226190658.GS2861@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <4dd94a34999d6db4ced7a0759c02f7cd93729dc4.1551160674.git.len.brown@intel.com>
On Tue, Feb 26, 2019 at 01:20:05AM -0500, Len Brown wrote:
> -static struct rapl_package *find_package_by_id(int id)
> +static struct rapl_package *rapl_find_package(int cpu)
> {
> + int id = topology_physical_package_id(cpu);
> struct rapl_package *rp;
Which you'll change to topology_physical_die_id() in the next patch.
If you respin the series again, could we pick a better name?
next prev parent reply other threads:[~2019-02-26 19:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <e2810a5317d3a109a98204e883fd1461f77b9339.1551160674.git.len.brown@intel.com>
2019-02-26 6:20 ` [PATCH 07/14] powercap/intel_rapl: Simplify rapl_find_package() Len Brown
2019-02-26 19:06 ` Peter Zijlstra [this message]
2019-03-26 18:27 ` Len Brown
2019-02-26 6:20 ` [PATCH 08/14] powercap/intel_rapl: Support multi-die/package Len Brown
2019-04-05 18:27 ` Thomas Gleixner
2019-04-05 18:27 ` Thomas Gleixner
2019-04-08 1:35 ` Zhang Rui
2019-04-08 1:35 ` Zhang Rui
2019-02-26 6:20 ` [PATCH 10/14] powercap/intel_rapl: update rapl domain name and debug messages Len Brown
2019-02-26 6:20 ` [PATCH 11/14] hwmon/coretemp: Support multi-die/package Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190226190658.GS2861@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox