Linux Power Management development
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, enric.balletbo@collabora.com,
	bleung@chromium.org, sre@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dlaurie@chromium.org,
	lamzin@google.com, bartfab@google.com, derat@google.com,
	groeck@google.com, dtor@google.com, sjg@chromium.org,
	jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: Re: [PATCH v3 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver
Date: Fri, 12 Apr 2019 23:52:43 +0800	[thread overview]
Message-ID: <201904122335.RtGa2sij%lkp@intel.com> (raw)
In-Reply-To: <20190412002055.92529-2-ncrews@chromium.org>

Hi Nick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc4 next-20190412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-Add-more-charge-types-and-CHARGE_CONTROL_-properties/20190412-211253


coccinelle warnings: (new ones prefixed by >>)

>> drivers/platform/chrome/wilco_ec/charge_config.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Nick Crews <ncrews@chromium.org>
Cc: kbuild-all@01.org, enric.balletbo@collabora.com,
	bleung@chromium.org, sre@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dlaurie@chromium.org,
	lamzin@google.com, bartfab@google.com, derat@google.com,
	groeck@google.com, dtor@google.com, sjg@chromium.org,
	jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: Re: [PATCH v3 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver
Date: Fri, 12 Apr 2019 23:52:43 +0800	[thread overview]
Message-ID: <201904122335.RtGa2sij%lkp@intel.com> (raw)
Message-ID: <20190412155243.RrOO00tlHNXMtvNz-Oymg-HJPgl7TAELUEyeO5Sv484@z> (raw)
In-Reply-To: <20190412002055.92529-2-ncrews@chromium.org>

Hi Nick,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc4 next-20190412]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-Add-more-charge-types-and-CHARGE_CONTROL_-properties/20190412-211253


coccinelle warnings: (new ones prefixed by >>)

>> drivers/platform/chrome/wilco_ec/charge_config.c:173:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

  parent reply	other threads:[~2019-04-12 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-12  0:20 [PATCH v3 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Nick Crews
2019-04-12  0:20 ` Nick Crews
2019-04-12  0:20 ` [PATCH v3 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-04-12  0:20   ` Nick Crews
2019-04-12 15:52   ` kbuild test robot [this message]
2019-04-12 15:52     ` kbuild test robot
2019-04-12 15:52   ` [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings kbuild test robot
2019-04-12 15:52     ` kbuild test robot
2019-04-15 14:53   ` [PATCH v3 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Enric Balletbo i Serra
2019-04-15 14:53     ` Enric Balletbo i Serra
2019-04-15 14:39 ` [PATCH v3 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties Enric Balletbo i Serra
2019-04-15 14:39   ` Enric Balletbo i Serra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201904122335.RtGa2sij%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bartfab@google.com \
    --cc=bleung@chromium.org \
    --cc=derat@google.com \
    --cc=dlaurie@chromium.org \
    --cc=dtor@google.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@google.com \
    --cc=jchwong@chromium.org \
    --cc=kbuild-all@01.org \
    --cc=lamzin@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=ncrews@chromium.org \
    --cc=sjg@chromium.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox