Linux Power Management development
 help / color / mirror / Atom feed
* [RFC PATCH soc-thermal] drivers: thermal: tsens: tsens_v1_feat can be static
  2019-04-23 17:23 [soc-thermal:linus 30/35] drivers/thermal/qcom/tsens-v1.c:147:29: sparse: sparse: symbol 'tsens_v1_feat' was not declared. Should it be static? kbuild test robot
@ 2019-04-23 17:23 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2019-04-23 17:23 UTC (permalink / raw)
  To: Amit Kucheria; +Cc: kbuild-all, linux-pm, Eduardo Valentin


Fixes: 5cb7aedfa7f2 ("drivers: thermal: tsens: Add generic support for TSENS v1 IP")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 tsens-v1.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c
index a1221ef..10b595d 100644
--- a/drivers/thermal/qcom/tsens-v1.c
+++ b/drivers/thermal/qcom/tsens-v1.c
@@ -144,7 +144,7 @@ static int calibrate_v1(struct tsens_priv *priv)
 
 /* v1.x: qcs404,405 */
 
-const struct tsens_features tsens_v1_feat = {
+static const struct tsens_features tsens_v1_feat = {
 	.ver_major	= VER_1_X,
 	.crit_int	= 0,
 	.adc		= 1,
@@ -152,7 +152,7 @@ const struct tsens_features tsens_v1_feat = {
 	.max_sensors	= 11,
 };
 
-const struct reg_field tsens_v1_regfields[MAX_REGFIELDS] = {
+static const struct reg_field tsens_v1_regfields[MAX_REGFIELDS] = {
 	/* ----- SROT ------ */
 	/* VERSION */
 	[VER_MAJOR] = REG_FIELD(SROT_HW_VER_OFF, 28, 31),

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [soc-thermal:linus 30/35] drivers/thermal/qcom/tsens-v1.c:147:29: sparse: sparse: symbol 'tsens_v1_feat' was not declared. Should it be static?
@ 2019-04-23 17:23 kbuild test robot
  2019-04-23 17:23 ` [RFC PATCH soc-thermal] drivers: thermal: tsens: tsens_v1_feat can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2019-04-23 17:23 UTC (permalink / raw)
  To: Amit Kucheria; +Cc: kbuild-all, linux-pm, Eduardo Valentin

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git linus
head:   0e50a5ee6b8a23c6798aae23efcd4b8e055c06ef
commit: 5cb7aedfa7f230060b73cfad49e3cdb45463e815 [30/35] drivers: thermal: tsens: Add generic support for TSENS v1 IP
reproduce:
        # apt-get install sparse
        git checkout 5cb7aedfa7f230060b73cfad49e3cdb45463e815
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>



sparse warnings: (new ones prefixed by >>)

>> drivers/thermal/qcom/tsens-v1.c:147:29: sparse: sparse: symbol 'tsens_v1_feat' was not declared. Should it be static?
>> drivers/thermal/qcom/tsens-v1.c:155:24: sparse: sparse: symbol 'tsens_v1_regfields' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-04-23 17:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-23 17:23 [soc-thermal:linus 30/35] drivers/thermal/qcom/tsens-v1.c:147:29: sparse: sparse: symbol 'tsens_v1_feat' was not declared. Should it be static? kbuild test robot
2019-04-23 17:23 ` [RFC PATCH soc-thermal] drivers: thermal: tsens: tsens_v1_feat can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox