[soc-thermal:linus 20/35] drivers/thermal/qcom/tsens-v0_1.c:322:29: sparse: sparse: symbol 'tsens_v0_1_feat' was not declared. Should it be static?

[soc-thermal:linus 20/35] drivers/thermal/qcom/tsens-v0_1.c:322:29: sparse: sparse: symbol 'tsens_v0_1_feat' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git linus
head:   0e50a5ee6b8a23c6798aae23efcd4b8e055c06ef
commit: 5be1c7f5f9ce74e41c193fb481f69de5b4d727ea [20/35] drivers: thermal: tsens: Introduce reg_fields to deal with register description
reproduce:
        # apt-get install sparse
        git checkout 5be1c7f5f9ce74e41c193fb481f69de5b4d727ea
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>



sparse warnings: (new ones prefixed by >>)

>> drivers/thermal/qcom/tsens-v0_1.c:322:29: sparse: sparse: symbol 'tsens_v0_1_feat' was not declared. Should it be static?
>> drivers/thermal/qcom/tsens-v0_1.c:329:24: sparse: sparse: symbol 'tsens_v0_1_regfields' was not declared. Should it be static?
--
>> drivers/thermal/qcom/tsens-v2.c:86:29: sparse: sparse: symbol 'tsens_v2_feat' was not declared. Should it be static?
>> drivers/thermal/qcom/tsens-v2.c:93:24: sparse: sparse: symbol 'tsens_v2_regfields' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH soc-thermal] drivers: thermal: tsens: tsens_v0_1_feat can be static

[kbuild test robot]

Fixes: 5be1c7f5f9ce ("drivers: thermal: tsens: Introduce reg_fields to deal with register description")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
 tsens-v0_1.c |    4 ++--
 tsens-v2.c   |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
index d171a4a..a7560e9 100644
--- a/drivers/thermal/qcom/tsens-v0_1.c
+++ b/drivers/thermal/qcom/tsens-v0_1.c
@@ -319,14 +319,14 @@ static int calibrate_8974(struct tsens_priv *priv)
 
 /* v0.1: 8916, 8974 */
 
-const struct tsens_features tsens_v0_1_feat = {
+static const struct tsens_features tsens_v0_1_feat = {
 	.ver_major	= VER_0_1,
 	.crit_int	= 0,
 	.adc		= 1,
 	.srot_split	= 1,
 };
 
-const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = {
+static const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = {
 	/* ----- SROT ------ */
 	/* No VERSION information */
 
diff --git a/drivers/thermal/qcom/tsens-v2.c b/drivers/thermal/qcom/tsens-v2.c
index e15a302..b58f5af 100644
--- a/drivers/thermal/qcom/tsens-v2.c
+++ b/drivers/thermal/qcom/tsens-v2.c
@@ -83,14 +83,14 @@ static int get_temp_tsens_v2(struct tsens_priv *priv, int id, int *temp)
 
 /* v2.x: 8996, 8998, sdm845 */
 
-const struct tsens_features tsens_v2_feat = {
+static const struct tsens_features tsens_v2_feat = {
 	.ver_major	= VER_2_X,
 	.crit_int	= 1,
 	.adc		= 0,
 	.srot_split	= 1,
 };
 
-const struct reg_field tsens_v2_regfields[MAX_REGFIELDS] = {
+static const struct reg_field tsens_v2_regfields[MAX_REGFIELDS] = {
 	/* ----- SROT ------ */
 	/* VERSION */
 	[VER_MAJOR] = REG_FIELD(SROT_HW_VER_OFF, 28, 31),

Re: [RFC PATCH soc-thermal] drivers: thermal: tsens: tsens_v0_1_feat can be static

[Amit Kucheria]

On Tue, Apr 23, 2019 at 10:37 PM kbuild test robot <lkp@intel.com> wrote:
>
>
> Fixes: 5be1c7f5f9ce ("drivers: thermal: tsens: Introduce reg_fields to deal with register description")
> Signed-off-by: kbuild test robot <lkp@intel.com>

Hi Eduardo,

Would you like me to fold these fixes back in and respin the series for merge?

Regards,
Amit


> ---
>  tsens-v0_1.c |    4 ++--
>  tsens-v2.c   |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-v0_1.c b/drivers/thermal/qcom/tsens-v0_1.c
> index d171a4a..a7560e9 100644
> --- a/drivers/thermal/qcom/tsens-v0_1.c
> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> @@ -319,14 +319,14 @@ static int calibrate_8974(struct tsens_priv *priv)
>
>  /* v0.1: 8916, 8974 */
>
> -const struct tsens_features tsens_v0_1_feat = {
> +static const struct tsens_features tsens_v0_1_feat = {
>         .ver_major      = VER_0_1,
>         .crit_int       = 0,
>         .adc            = 1,
>         .srot_split     = 1,
>  };
>
> -const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = {
> +static const struct reg_field tsens_v0_1_regfields[MAX_REGFIELDS] = {
>         /* ----- SROT ------ */
>         /* No VERSION information */
>
> diff --git a/drivers/thermal/qcom/tsens-v2.c b/drivers/thermal/qcom/tsens-v2.c
> index e15a302..b58f5af 100644
> --- a/drivers/thermal/qcom/tsens-v2.c
> +++ b/drivers/thermal/qcom/tsens-v2.c
> @@ -83,14 +83,14 @@ static int get_temp_tsens_v2(struct tsens_priv *priv, int id, int *temp)
>
>  /* v2.x: 8996, 8998, sdm845 */
>
> -const struct tsens_features tsens_v2_feat = {
> +static const struct tsens_features tsens_v2_feat = {
>         .ver_major      = VER_2_X,
>         .crit_int       = 1,
>         .adc            = 0,
>         .srot_split     = 1,
>  };
>
> -const struct reg_field tsens_v2_regfields[MAX_REGFIELDS] = {
> +static const struct reg_field tsens_v2_regfields[MAX_REGFIELDS] = {
>         /* ----- SROT ------ */
>         /* VERSION */
>         [VER_MAJOR] = REG_FIELD(SROT_HW_VER_OFF, 28, 31),