From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"Raju P . L . S . S . S . N" <rplsssn@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@kernel.org>,
Lina Iyer <ilina@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh@kernel.org>
Subject: [PATCH 1/4] PM / Domains: Use the base device for driver_deferred_probe_check_state()
Date: Thu, 25 Apr 2019 11:04:10 +0200 [thread overview]
Message-ID: <20190425090413.10700-2-ulf.hansson@linaro.org> (raw)
In-Reply-To: <20190425090413.10700-1-ulf.hansson@linaro.org>
When genpd fails to attach a device to one of its multiple PM domains, we
end up calling driver_deferred_probe_check_state() for the recently
allocated virtual device. This is wrong, as it's the base device that is
being probed. Fix this, by passing along the base device to
__genpd_dev_pm_attach() and use that instead.
Fixes: e01afc325025 ("PM / Domains: Stop deferring probe at the end of initcall")
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/base/power/domain.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 8362dfe187f5..8aca1c9b4406 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -2405,8 +2405,8 @@ static void genpd_dev_pm_sync(struct device *dev)
genpd_queue_power_off_work(pd);
}
-static int __genpd_dev_pm_attach(struct device *dev, unsigned int index,
- bool power_on)
+static int __genpd_dev_pm_attach(struct device *dev, struct device *base_dev,
+ unsigned int index, bool power_on)
{
struct of_phandle_args pd_args;
struct generic_pm_domain *pd;
@@ -2424,7 +2424,7 @@ static int __genpd_dev_pm_attach(struct device *dev, unsigned int index,
mutex_unlock(&gpd_list_lock);
dev_dbg(dev, "%s() failed to find PM domain: %ld\n",
__func__, PTR_ERR(pd));
- return driver_deferred_probe_check_state(dev);
+ return driver_deferred_probe_check_state(base_dev);
}
dev_dbg(dev, "adding to PM domain %s\n", pd->name);
@@ -2480,7 +2480,7 @@ int genpd_dev_pm_attach(struct device *dev)
"#power-domain-cells") != 1)
return 0;
- return __genpd_dev_pm_attach(dev, 0, true);
+ return __genpd_dev_pm_attach(dev, dev, 0, true);
}
EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
@@ -2533,7 +2533,7 @@ struct device *genpd_dev_pm_attach_by_id(struct device *dev,
}
/* Try to attach the device to the PM domain at the specified index. */
- ret = __genpd_dev_pm_attach(virt_dev, index, false);
+ ret = __genpd_dev_pm_attach(virt_dev, dev, index, false);
if (ret < 1) {
device_unregister(virt_dev);
return ret ? ERR_PTR(ret) : NULL;
--
2.17.1
next prev parent reply other threads:[~2019-04-25 9:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 9:04 [PATCH 0/4] PM / Domains: Improve support for CPUs in genpd Ulf Hansson
2019-04-25 9:04 ` Ulf Hansson
2019-04-25 9:04 ` Ulf Hansson [this message]
2019-04-25 9:04 ` [PATCH 1/4] PM / Domains: Use the base device for driver_deferred_probe_check_state() Ulf Hansson
2019-04-25 9:39 ` Viresh Kumar
2019-04-25 9:39 ` Viresh Kumar
2019-04-25 9:04 ` [PATCH 2/4] PM / Domains: Drop unused in-parameter to some genpd functions Ulf Hansson
2019-04-25 9:04 ` Ulf Hansson
2019-04-25 9:40 ` Viresh Kumar
2019-04-25 9:40 ` Viresh Kumar
2019-04-25 9:04 ` [PATCH 3/4] PM / Domains: Search for the CPU device outside the genpd lock Ulf Hansson
2019-04-25 9:04 ` Ulf Hansson
2019-04-25 9:45 ` Viresh Kumar
2019-04-25 9:45 ` Viresh Kumar
2019-04-25 10:14 ` Ulf Hansson
2019-04-25 10:14 ` Ulf Hansson
2019-04-25 10:17 ` Viresh Kumar
2019-04-25 10:17 ` Viresh Kumar
2019-04-25 9:04 ` [PATCH 4/4] PM / Domains: Allow to attach a CPU via genpd_dev_pm_attach_by_id|name() Ulf Hansson
2019-04-25 9:04 ` Ulf Hansson
2019-04-25 9:47 ` Viresh Kumar
2019-04-25 9:47 ` Viresh Kumar
2019-04-25 9:56 ` [PATCH 0/4] PM / Domains: Improve support for CPUs in genpd Rafael J. Wysocki
2019-04-25 9:56 ` Rafael J. Wysocki
2019-04-25 10:11 ` Ulf Hansson
2019-04-25 10:11 ` Ulf Hansson
2019-04-25 10:14 ` Rafael J. Wysocki
2019-04-25 10:14 ` Rafael J. Wysocki
2019-04-25 10:17 ` Ulf Hansson
2019-04-25 10:17 ` Ulf Hansson
2019-04-25 10:32 ` Rafael J. Wysocki
2019-04-25 10:32 ` Rafael J. Wysocki
2019-05-01 10:42 ` Rafael J. Wysocki
2019-05-01 10:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190425090413.10700-2-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=ilina@codeaurora.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox