[pm:linux-next 91/102] include/linux/pm_qos.h:197:9: error: expected '(' before 'type'

[pm:linux-next 91/102] include/linux/pm_qos.h:197:9: error: expected '(' before 'type'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 2844 bytes --]

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
head:   267eacd79cadd5e2d6307320497d66119907c411
commit: 57fa6137402b98327d1247c5aaf3d4f0595a73fe [91/102] PM / QOS: Pass request type to dev_pm_qos_read_value()
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 57fa6137402b98327d1247c5aaf3d4f0595a73fe
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from kernel//power/qos.c:33:0:
   include/linux/pm_qos.h: In function 'dev_pm_qos_read_value':
>> include/linux/pm_qos.h:197:9: error: expected '(' before 'type'
     switch type {
            ^~~~
   include/linux/pm_qos.h:197:9: warning: statement with no effect [-Wunused-value]
>> include/linux/pm_qos.h:204:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
   include/linux/pm_qos.h: At top level:
   include/linux/pm_qos.h:219:4: error: expected identifier or '(' before '{' token
       { return 0; }
       ^
   include/linux/pm_qos.h:216:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function]
    static inline int dev_pm_qos_add_notifier(struct device *dev,
                      ^~~~~~~~~~~~~~~~~~~~~~~

vim +197 include/linux/pm_qos.h

   178	
   179	static inline s32 dev_pm_qos_raw_resume_latency(struct device *dev)
   180	{
   181		return IS_ERR_OR_NULL(dev->power.qos) ?
   182			PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
   183			pm_qos_read_value(&dev->power.qos->resume_latency);
   184	}
   185	#else
   186	static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
   187								  s32 mask)
   188				{ return PM_QOS_FLAGS_UNDEFINED; }
   189	static inline enum pm_qos_flags_status dev_pm_qos_flags(struct device *dev,
   190								s32 mask)
   191				{ return PM_QOS_FLAGS_UNDEFINED; }
   192	static inline s32 __dev_pm_qos_resume_latency(struct device *dev)
   193				{ return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; }
   194	static inline s32 dev_pm_qos_read_value(struct device *dev,
   195						enum dev_pm_qos_req_type type)
   196	{
 > 197		switch type {
   198		case DEV_PM_QOS_RESUME_LATENCY:
   199			return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT;
   200		default:
   201			WARN_ON(1);
   202			return 0;
   203		}
 > 204	}
   205	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5119 bytes --]

Re: [pm:linux-next 91/102] include/linux/pm_qos.h:197:9: error: expected '(' before 'type'

[Viresh Kumar]

On 04-07-19, 09:04, kbuild test robot wrote:
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
> head:   267eacd79cadd5e2d6307320497d66119907c411
> commit: 57fa6137402b98327d1247c5aaf3d4f0595a73fe [91/102] PM / QOS: Pass request type to dev_pm_qos_read_value()
> config: riscv-allnoconfig (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 7.4.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 57fa6137402b98327d1247c5aaf3d4f0595a73fe
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.4.0 make.cross ARCH=riscv 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from kernel//power/qos.c:33:0:
>    include/linux/pm_qos.h: In function 'dev_pm_qos_read_value':
> >> include/linux/pm_qos.h:197:9: error: expected '(' before 'type'
>      switch type {
>             ^~~~
>    include/linux/pm_qos.h:197:9: warning: statement with no effect [-Wunused-value]
> >> include/linux/pm_qos.h:204:1: warning: no return statement in function returning non-void [-Wreturn-type]
>     }
>     ^
>    include/linux/pm_qos.h: At top level:
>    include/linux/pm_qos.h:219:4: error: expected identifier or '(' before '{' token
>        { return 0; }
>        ^
>    include/linux/pm_qos.h:216:19: warning: 'dev_pm_qos_add_notifier' declared 'static' but never defined [-Wunused-function]
>     static inline int dev_pm_qos_add_notifier(struct device *dev,

Very embarrassing. Fixed these two now. Thanks.

-- 
viresh