* [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id
[not found] <20191210145345.11616-1-sudeep.holla@arm.com>
@ 2019-12-10 14:53 ` Sudeep Holla
2019-12-11 2:39 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2019-12-10 14:53 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: Sudeep Holla, Cristian Marussi, Rafael J. Wysocki, Viresh Kumar,
linux-pm
The scmi bus now has support to match the driver with devices not only
based on their protocol id but also based on their device name if one is
available. This was added to cater the need to support multiple devices
and drivers for the same protocol.
Let us add the name "cpufreq" to scmi_device_id table in the driver so
that in matches only with device with the same name and protocol id
SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver.
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/cpufreq/scmi-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index e6182c89df79..61623e2ff149 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev)
}
static const struct scmi_device_id scmi_id_table[] = {
- { SCMI_PROTOCOL_PERF },
+ { SCMI_PROTOCOL_PERF, "cpufreq" },
{ },
};
MODULE_DEVICE_TABLE(scmi, scmi_id_table);
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id
2019-12-10 14:53 ` [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id Sudeep Holla
@ 2019-12-11 2:39 ` Viresh Kumar
2019-12-11 10:13 ` Sudeep Holla
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2019-12-11 2:39 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-arm-kernel, linux-kernel, Cristian Marussi,
Rafael J. Wysocki, linux-pm
On 10-12-19, 14:53, Sudeep Holla wrote:
> The scmi bus now has support to match the driver with devices not only
> based on their protocol id but also based on their device name if one is
> available. This was added to cater the need to support multiple devices
> and drivers for the same protocol.
>
> Let us add the name "cpufreq" to scmi_device_id table in the driver so
> that in matches only with device with the same name and protocol id
> SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver.
>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index e6182c89df79..61623e2ff149 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev)
> }
>
> static const struct scmi_device_id scmi_id_table[] = {
> - { SCMI_PROTOCOL_PERF },
> + { SCMI_PROTOCOL_PERF, "cpufreq" },
> { },
> };
> MODULE_DEVICE_TABLE(scmi, scmi_id_table);
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id
2019-12-11 2:39 ` Viresh Kumar
@ 2019-12-11 10:13 ` Sudeep Holla
2019-12-11 10:30 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Sudeep Holla @ 2019-12-11 10:13 UTC (permalink / raw)
To: Viresh Kumar
Cc: linux-arm-kernel, linux-kernel, Cristian Marussi,
Rafael J. Wysocki, linux-pm
On Wed, Dec 11, 2019 at 08:09:09AM +0530, Viresh Kumar wrote:
> On 10-12-19, 14:53, Sudeep Holla wrote:
> > The scmi bus now has support to match the driver with devices not only
> > based on their protocol id but also based on their device name if one is
> > available. This was added to cater the need to support multiple devices
> > and drivers for the same protocol.
> >
> > Let us add the name "cpufreq" to scmi_device_id table in the driver so
> > that in matches only with device with the same name and protocol id
> > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver.
> >
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: linux-pm@vger.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > drivers/cpufreq/scmi-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> > index e6182c89df79..61623e2ff149 100644
> > --- a/drivers/cpufreq/scmi-cpufreq.c
> > +++ b/drivers/cpufreq/scmi-cpufreq.c
> > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev)
> > }
> >
> > static const struct scmi_device_id scmi_id_table[] = {
> > - { SCMI_PROTOCOL_PERF },
> > + { SCMI_PROTOCOL_PERF, "cpufreq" },
> > { },
> > };
> > MODULE_DEVICE_TABLE(scmi, scmi_id_table);
>
> Applied. Thanks.
This will break the build without patch 1/15, so preferably must go as
part of the series. Sorry for not missing to specify that detail.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id
2019-12-11 10:13 ` Sudeep Holla
@ 2019-12-11 10:30 ` Viresh Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2019-12-11 10:30 UTC (permalink / raw)
To: Sudeep Holla
Cc: linux-arm-kernel, linux-kernel, Cristian Marussi,
Rafael J. Wysocki, linux-pm
On 11-12-19, 10:13, Sudeep Holla wrote:
> On Wed, Dec 11, 2019 at 08:09:09AM +0530, Viresh Kumar wrote:
> > On 10-12-19, 14:53, Sudeep Holla wrote:
> > > The scmi bus now has support to match the driver with devices not only
> > > based on their protocol id but also based on their device name if one is
> > > available. This was added to cater the need to support multiple devices
> > > and drivers for the same protocol.
> > >
> > > Let us add the name "cpufreq" to scmi_device_id table in the driver so
> > > that in matches only with device with the same name and protocol id
> > > SCMI_PROTOCOL_PERF. This will help to add "devfreq" device/driver.
> > >
> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > > Cc: linux-pm@vger.kernel.org
> > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > > ---
> > > drivers/cpufreq/scmi-cpufreq.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> > > index e6182c89df79..61623e2ff149 100644
> > > --- a/drivers/cpufreq/scmi-cpufreq.c
> > > +++ b/drivers/cpufreq/scmi-cpufreq.c
> > > @@ -261,7 +261,7 @@ static void scmi_cpufreq_remove(struct scmi_device *sdev)
> > > }
> > >
> > > static const struct scmi_device_id scmi_id_table[] = {
> > > - { SCMI_PROTOCOL_PERF },
> > > + { SCMI_PROTOCOL_PERF, "cpufreq" },
> > > { },
> > > };
> > > MODULE_DEVICE_TABLE(scmi, scmi_id_table);
> >
> > Applied. Thanks.
>
> This will break the build without patch 1/15, so preferably must go as
> part of the series. Sorry for not missing to specify that detail.
Dropped now.
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-11 10:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191210145345.11616-1-sudeep.holla@arm.com>
2019-12-10 14:53 ` [PATCH 13/15] cpufreq: scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-11 2:39 ` Viresh Kumar
2019-12-11 10:13 ` Sudeep Holla
2019-12-11 10:30 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox