* RE: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error [not found] ` <20200614091203.GC2878@kunai> @ 2020-06-15 6:33 ` Aisheng Dong 2020-06-15 7:06 ` Wolfram Sang 0 siblings, 1 reply; 3+ messages in thread From: Aisheng Dong @ 2020-06-15 6:33 UTC (permalink / raw) To: Wolfram Sang, Dinghao Liu, linux-pm@vger.kernel.org, Ulf Hansson, Rafael J . Wysocki Cc: kjlu@umn.edu, Markus Elfring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Andy Duan, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > From: Wolfram Sang <wsa@kernel.org> > Sent: Sunday, June 14, 2020 5:12 PM > > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > > pm_runtime_get_sync() increments the runtime PM usage counter even the > > call returns an error code. Thus a corresponding decrement is needed > > on the error handling path to keep the counter balanced. > > Can you point me to a discussion where it was decided that this is a proper fix? > I'd think we rather should fix pm_runtime_get_sync() but maybe there are > technical reasons against it. I had the same feeling. Copy pm guys to comments. Regards Aisheng ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error 2020-06-15 6:33 ` [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Aisheng Dong @ 2020-06-15 7:06 ` Wolfram Sang 2020-06-15 7:40 ` Markus Elfring 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2020-06-15 7:06 UTC (permalink / raw) To: Aisheng Dong Cc: Dinghao Liu, linux-pm@vger.kernel.org, Ulf Hansson, Rafael J . Wysocki, kjlu@umn.edu, Markus Elfring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, dl-linux-imx, Andy Duan, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 851 bytes --] On Mon, Jun 15, 2020 at 06:33:40AM +0000, Aisheng Dong wrote: > > From: Wolfram Sang <wsa@kernel.org> > > Sent: Sunday, June 14, 2020 5:12 PM > > > > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote: > > > pm_runtime_get_sync() increments the runtime PM usage counter even the > > > call returns an error code. Thus a corresponding decrement is needed > > > on the error handling path to keep the counter balanced. > > > > Can you point me to a discussion where it was decided that this is a proper fix? > > I'd think we rather should fix pm_runtime_get_sync() but maybe there are > > technical reasons against it. > > I had the same feeling. > Copy pm guys to comments. I started a seperate thread: https://lkml.org/lkml/2020/6/14/76 Still, on-going discussion if the proper fix is to remove the error check. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error 2020-06-15 7:06 ` Wolfram Sang @ 2020-06-15 7:40 ` Markus Elfring 0 siblings, 0 replies; 3+ messages in thread From: Markus Elfring @ 2020-06-15 7:40 UTC (permalink / raw) To: Wolfram Sang, linux-pm, kernel, linux-imx, linux-i2c, linux-arm-kernel Cc: Aisheng Dong, Dinghao Liu, Ulf Hansson, Rafael J . Wysocki, Shawn Guo, Sascha Hauer, Fabio Estevam, Andy Duan, linux-kernel, Qiushi Wu, Navid Emamdoost, Kangjie Lu, Aditya Pakki > I started a seperate thread: > > https://lkml.org/lkml/2020/6/14/76 > > Still, on-going discussion if the proper fix is to remove the error check. I find that a bit of additional information can make such a link safer. RFC: a failing pm_runtime_get increases the refcnt? https://lore.kernel.org/lkml/20200614090751.GA2878@kunai/ How will the clarification of corresponding software aspects evolve further? Regards, Markus ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 7:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200601061640.27632-1-dinghao.liu@zju.edu.cn>
[not found] ` <20200614091203.GC2878@kunai>
2020-06-15 6:33 ` [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Aisheng Dong
2020-06-15 7:06 ` Wolfram Sang
2020-06-15 7:40 ` Markus Elfring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox