From: Bjorn Helgaas <helgaas@kernel.org>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
Linux PM <linux-pm@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Sasha Netfin <sasha.neftin@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Stefan Assmann <sassmann@redhat.com>,
David Miller <davem@davemloft.net>,
darcari@redhat.com, Yijun.Shen@dell.com, Perry.Yuan@dell.com
Subject: Re: [PATCH v2 2/5] e1000e: Move all s0ix related code into it's own source file
Date: Wed, 2 Dec 2020 14:11:00 -0600 [thread overview]
Message-ID: <20201202201100.GA1466664@bjorn-Precision-5520> (raw)
In-Reply-To: <20201202161748.128938-3-mario.limonciello@dell.com>
s/it's/its/ (in subject as well as below).
Previous patches used "S0ix", not "s0ix" (in subject as well as
below, as well as subject and commit log of 3/5 and 5/5).
On Wed, Dec 02, 2020 at 10:17:45AM -0600, Mario Limonciello wrote:
> Introduce a flag to indicate the device should be using the s0ix
> flows and use this flag to run those functions.
Would be nicer to have a move that does nothing else + a separate
patch that adds a flag so it's more obvious, but again, not my circus.
> Splitting the code to it's own file will make future heuristics
> more self containted.
s/containted/contained/
Bjorn
next prev parent reply other threads:[~2020-12-02 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 16:17 [PATCH v2 0/5] Improve s0ix flows for systems i219LM Mario Limonciello
2020-12-02 16:17 ` [PATCH v2 1/5] e1000e: fix S0ix flow to allow S0i3.2 subset entry Mario Limonciello
2020-12-02 20:10 ` Bjorn Helgaas
2020-12-02 16:17 ` [PATCH v2 2/5] e1000e: Move all s0ix related code into it's own source file Mario Limonciello
2020-12-02 20:11 ` Bjorn Helgaas [this message]
2020-12-02 16:17 ` [PATCH v2 3/5] e1000e: Add Dell's Comet Lake systems into s0ix heuristics Mario Limonciello
2020-12-02 16:17 ` [PATCH v2 4/5] e1000e: Add more Dell CML " Mario Limonciello
2020-12-02 20:12 ` Bjorn Helgaas
2020-12-02 16:17 ` [PATCH v2 5/5] e1000e: Export s0ix flags to ethtool Mario Limonciello
2020-12-02 19:06 ` [PATCH v2 0/5] Improve s0ix flows for systems i219LM Jakub Kicinski
2020-12-02 19:24 ` Limonciello, Mario
2020-12-02 20:14 ` Bjorn Helgaas
2020-12-02 20:23 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202201100.GA1466664@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Perry.Yuan@dell.com \
--cc=Yijun.Shen@dell.com \
--cc=aaron.f.brown@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=anthony.l.nguyen@intel.com \
--cc=darcari@redhat.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox