* [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226
@ 2021-11-18 21:02 Luca Weiss
2021-11-18 21:02 ` [PATCH 2/7] power: supply: qcom_smbb: support pm8226 Luca Weiss
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Luca Weiss @ 2021-11-18 21:02 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss,
Sebastian Reichel, Rob Herring, linux-pm, devicetree,
linux-kernel
The charger in PM8226 (used in MSM8226) is similar to the charger in
PM8941.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
.../devicetree/bindings/power/supply/qcom,pm8941-charger.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
index bc8904872d1b..caeff68c66d5 100644
--- a/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
+++ b/Documentation/devicetree/bindings/power/supply/qcom,pm8941-charger.yaml
@@ -11,7 +11,9 @@ maintainers:
properties:
compatible:
- const: qcom,pm8941-charger
+ enum:
+ - qcom,pm8226-charger
+ - qcom,pm8941-charger
reg:
maxItems: 1
--
2.34.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/7] power: supply: qcom_smbb: support pm8226
2021-11-18 21:02 [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Luca Weiss
@ 2021-11-18 21:02 ` Luca Weiss
2021-11-30 11:03 ` Sebastian Reichel
2021-11-29 23:11 ` [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Rob Herring
2022-01-31 18:24 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Luca Weiss @ 2021-11-18 21:02 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Sebastian Reichel, linux-pm, linux-kernel
PM8226 (used in MSM8226) has v1 smbb hardware and works fine with the
current driver.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
drivers/power/supply/qcom_smbb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
index 84cc9fba029d..bd50124eef9f 100644
--- a/drivers/power/supply/qcom_smbb.c
+++ b/drivers/power/supply/qcom_smbb.c
@@ -863,8 +863,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
}
chg->revision += 1;
- if (chg->revision != 2 && chg->revision != 3) {
- dev_err(&pdev->dev, "v1 hardware not supported\n");
+ if (chg->revision != 1 && chg->revision != 2 && chg->revision != 3) {
+ dev_err(&pdev->dev, "v%d hardware not supported\n", chg->revision);
return -ENODEV;
}
dev_info(&pdev->dev, "Initializing SMBB rev %u", chg->revision);
@@ -1012,6 +1012,7 @@ static int smbb_charger_remove(struct platform_device *pdev)
}
static const struct of_device_id smbb_charger_id_table[] = {
+ { .compatible = "qcom,pm8226-charger" },
{ .compatible = "qcom,pm8941-charger" },
{ }
};
--
2.34.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226
2021-11-18 21:02 [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Luca Weiss
2021-11-18 21:02 ` [PATCH 2/7] power: supply: qcom_smbb: support pm8226 Luca Weiss
@ 2021-11-29 23:11 ` Rob Herring
2021-11-30 11:02 ` Sebastian Reichel
2022-01-31 18:24 ` (subset) " Bjorn Andersson
2 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-11-29 23:11 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-kernel, ~postmarketos/upstreaming, linux-arm-msm,
Sebastian Reichel, Rob Herring, devicetree, phone-devel, linux-pm
On Thu, 18 Nov 2021 22:02:04 +0100, Luca Weiss wrote:
> The charger in PM8226 (used in MSM8226) is similar to the charger in
> PM8941.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> .../devicetree/bindings/power/supply/qcom,pm8941-charger.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226
2021-11-29 23:11 ` [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Rob Herring
@ 2021-11-30 11:02 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2021-11-30 11:02 UTC (permalink / raw)
To: Rob Herring
Cc: Luca Weiss, linux-kernel, ~postmarketos/upstreaming,
linux-arm-msm, Rob Herring, devicetree, phone-devel, linux-pm
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
Hi,
On Mon, Nov 29, 2021 at 05:11:00PM -0600, Rob Herring wrote:
> On Thu, 18 Nov 2021 22:02:04 +0100, Luca Weiss wrote:
> > The charger in PM8226 (used in MSM8226) is similar to the charger in
> > PM8941.
> >
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > .../devicetree/bindings/power/supply/qcom,pm8941-charger.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/7] power: supply: qcom_smbb: support pm8226
2021-11-18 21:02 ` [PATCH 2/7] power: supply: qcom_smbb: support pm8226 Luca Weiss
@ 2021-11-30 11:03 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2021-11-30 11:03 UTC (permalink / raw)
To: Luca Weiss
Cc: linux-arm-msm, ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]
Hi,
On Thu, Nov 18, 2021 at 10:02:05PM +0100, Luca Weiss wrote:
> PM8226 (used in MSM8226) has v1 smbb hardware and works fine with the
> current driver.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/qcom_smbb.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/supply/qcom_smbb.c b/drivers/power/supply/qcom_smbb.c
> index 84cc9fba029d..bd50124eef9f 100644
> --- a/drivers/power/supply/qcom_smbb.c
> +++ b/drivers/power/supply/qcom_smbb.c
> @@ -863,8 +863,8 @@ static int smbb_charger_probe(struct platform_device *pdev)
> }
>
> chg->revision += 1;
> - if (chg->revision != 2 && chg->revision != 3) {
> - dev_err(&pdev->dev, "v1 hardware not supported\n");
> + if (chg->revision != 1 && chg->revision != 2 && chg->revision != 3) {
> + dev_err(&pdev->dev, "v%d hardware not supported\n", chg->revision);
> return -ENODEV;
> }
> dev_info(&pdev->dev, "Initializing SMBB rev %u", chg->revision);
> @@ -1012,6 +1012,7 @@ static int smbb_charger_remove(struct platform_device *pdev)
> }
>
> static const struct of_device_id smbb_charger_id_table[] = {
> + { .compatible = "qcom,pm8226-charger" },
> { .compatible = "qcom,pm8941-charger" },
> { }
> };
> --
> 2.34.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226
2021-11-18 21:02 [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Luca Weiss
2021-11-18 21:02 ` [PATCH 2/7] power: supply: qcom_smbb: support pm8226 Luca Weiss
2021-11-29 23:11 ` [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Rob Herring
@ 2022-01-31 18:24 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2022-01-31 18:24 UTC (permalink / raw)
To: linux-arm-msm, Luca Weiss
Cc: phone-devel, devicetree, ~postmarketos/upstreaming, Rob Herring,
linux-pm, Sebastian Reichel, linux-kernel
On Thu, 18 Nov 2021 22:02:04 +0100, Luca Weiss wrote:
> The charger in PM8226 (used in MSM8226) is similar to the charger in
> PM8941.
>
>
Applied, thanks!
[3/7] ARM: dts: qcom: pm8226: add smbb charger node
commit: b64192272cb65b0fddb97dba7c4f244452954a85
[4/7] ARM: dts: qcom: apq8026-lg-lenok: configure SMBB charger
commit: 0bbcddc5f0365937ed53ebf7daa98134a6ebce8d
[5/7] dt-bindings: phy: qcom,usb-hs-phy: add MSM8226 compatible
commit: c04421c68fd40ee33df87eea69c1a447b7985d0d
[6/7] ARM: dts: qcom: msm8226: add USB node
commit: 1a34117f2e145f158c339ad9d296c0c1c42bc504
[7/7] ARM: dts: qcom: apq8026-lg-lenok: enable USB
commit: f8565bd5404fcd6f87ee1e2d585541fbb457612d
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-31 18:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-18 21:02 [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Luca Weiss
2021-11-18 21:02 ` [PATCH 2/7] power: supply: qcom_smbb: support pm8226 Luca Weiss
2021-11-30 11:03 ` Sebastian Reichel
2021-11-29 23:11 ` [PATCH 1/7] dt-bindings: power: supply: pm8941-charger: add pm8226 Rob Herring
2021-11-30 11:02 ` Sebastian Reichel
2022-01-31 18:24 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox