Linux Power Management development
 help / color / mirror / Atom feed
From: Chen Yu <yu.c.chen@intel.com>
To: Kin Cho <kin.cho@oracle.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Len Brown <lenb@kernel.org>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Linux PM Mailing List <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] tools/power/turbostat: Remove Package C6 Retention on Ice Lake Server
Date: Sat, 5 Mar 2022 17:20:57 +0800	[thread overview]
Message-ID: <20220305092057.GA8207@chenyu5-mobl1> (raw)
In-Reply-To: <01dd04dd-a2ad-6ee2-4a8f-f801908e4299@oracle.com>

Hi Cho,
On Fri, Mar 04, 2022 at 01:35:17PM -0800, Kin Cho wrote:
> Hi,
> 
> This patch (25368d7cefcd87a94ccabcc6f9f31796607bbe4e) has affected Sapphire
> Rapids support.
> Specifically Pkg%pc2 and Pkg%pc6 are now missing on Sapphire Rapids (with
> package C6 retention).
> See below for a diff of turbostat --list output with and without 25368d7.
> 
> -kin
> 
> --- turbostat-0304_115100-v5.12-10-g25368d7cefcd    2022-03-04
> 11:51:00.184727582 -0800
> +++ turbostat-0304_124741-v5.12-10-g25368d7cefcd--25368d7 2022-03-04
> 12:47:41.543801798 -0800
> @@ -1,2 +1,2 @@
>  turbostat version 21.03.12 - Len Brown <lenb@kernel.org>
> -usec,Time_Of_Day_Seconds,Package,Core,CPU,APIC,X2APIC,Avg_MHz,Busy%,Bzy_MHz,TSC_MHz,IPC,IRQ,SMI,POLL,C1ACPI,C2ACPI,POLL%,C1ACPI%,C2ACPI%,CPU%c1,CPU%c6,CoreTmp,PkgTmp,PkgWatt,RAMWatt,PKG_%,RAM_%
> +usec,Time_Of_Day_Seconds,Package,Core,CPU,APIC,X2APIC,Avg_MHz,Busy%,Bzy_MHz,TSC_MHz,IPC,IRQ,SMI,POLL,C1ACPI,C2ACPI,POLL%,C1ACPI%,C2ACPI%,CPU%c1,CPU%c6,CoreTmp,PkgTmp,Pkg%pc2,Pkg%pc6,PkgWatt,RAMWatt,PKG_%,RAM_%
>
My guess is that the max limited package c-state exposed might be '3' rather than '2'.
Artem has previously found this issue on ICX and there is a patch:
https://patchwork.kernel.org/project/linux-pm/patch/20211004105224.3145916-1-dedekind1@gmail.com/
would you please help check if that helps?

thanks,
Chenyu

  reply	other threads:[~2022-03-05  9:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 14:52 [PATCH] tools/power/turbostat: Remove Package C6 Retention on Ice Lake Server Artem Bityutskiy
2022-03-04 21:35 ` Kin Cho
2022-03-05  9:20   ` Chen Yu [this message]
     [not found]     ` <61b2d82dd53f5cc3609f095b60ad8afe8c085f39.camel@linux.intel.com>
2022-03-07 20:31       ` [External] : " Kin Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220305092057.GA8207@chenyu5-mobl1 \
    --to=yu.c.chen@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dedekind1@gmail.com \
    --cc=kin.cho@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox