Re: [External] : Re: [PATCH] tools/power/turbostat: Remove Package C6 Retention on Ice Lake Server

[Kin Cho <kin.cho@oracle.com>]

Hi Artem, Chen,

The patch "turbostat: fix PC6 displaying on some systems" fixes the 
issue on our Sapphire Rapids system.
On this system I also checked MAX_PKG_C_STATE, and it is 3.

Thanks,

-kin

On 3/6/22 6:35 AM, Artem Bityutskiy wrote:
> On Sat, 2022-03-05 at 17:20 +0800, Chen Yu wrote:
>> Hi Cho,
>> On Fri, Mar 04, 2022 at 01:35:17PM -0800, Kin Cho wrote:
>>> Hi,
>>>
>>> This patch (25368d7cefcd87a94ccabcc6f9f31796607bbe4e) has affected 
>>> Sapphire
>>> Rapids support.
>>> Specifically Pkg%pc2 and Pkg%pc6 are now missing on Sapphire Rapids 
>>> (with
>>> package C6 retention).
>>> See below for a diff of turbostat --list output with and without 
>>> 25368d7.
>>>
>> My guess is that the max limited package c-state exposed might be '3' 
>> rather than '2'.
>> Artem has previously found this issue on ICX and there is a patch:
>> https://patchwork.kernel.org/project/linux-pm/patch/20211004105224.3145916-1-dedekind1@gmail.com/ 
>> <https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-pm/patch/20211004105224.3145916-1-dedekind1@gmail.com/__;!!ACWV5N9M2RV99hQ!c44scI9uwc_oZRla1MmeuL9IJVimON-bjStsp8_FIh3icFJoju9aMrt6LpMCcA$>
>> would you please help check if that helps?
>
> Yes, this patch fixes the problem.
>
> Rafael, would you please take a look and possibly pick it? Thanks!
>
> Artem.
>