From: Sudeep Holla <sudeep.holla@arm.com>
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: linuix-kernel@vger.kernel.org, Ionela.Voinescu@arm.com,
Sudeep Holla <sudeep.holla@arm.com>,
Dietmar.Eggemann@arm.com, "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org,
devel@acpica.org
Subject: Re: [PATCH v1 5/5] cpufreq: CPPC: Enable dvfs_possible_from_any_cpu
Date: Wed, 11 May 2022 15:50:53 +0100 [thread overview]
Message-ID: <20220511145053.mszsbcqsytf6tmfh@bogus> (raw)
In-Reply-To: <20220511134559.1466925-5-pierre.gondois@arm.com>
On Wed, May 11, 2022 at 03:45:59PM +0200, Pierre Gondois wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> The communication mean of the _CPC desired performance can be
> PCC, System Memory, System IO, or Functional Fixed Hardware (FFH).
>
> PCC, SystemMemory and SystemIo address spaces are available from any
> CPU. Thus, dvfs_possible_from_any_cpu should be enabled in such case.
> For FFH, let the FFH implementation do smp_call_function_*() calls.
>
Fair enough. I just thought it would be good to check if this is already
taken care for Arm platforms and found that we don't support it yet. So all
is fine :).
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 000a0c610c30..ad1535fbf389 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -558,6 +558,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy)
> }
>
> policy->fast_switch_possible = cppc_allow_fast_switch();
> + policy->dvfs_possible_from_any_cpu = true;
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-05-11 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:45 [PATCH v1 1/5] ACPI: CPPC: Check _OSC for flexible address space Pierre Gondois
2022-05-11 13:45 ` [PATCH v1 2/5] ACPI: bus: Set CPPC _OSC bits for all and when CPPC_LIB is supported Pierre Gondois
2022-05-11 14:22 ` Sudeep Holla
2022-05-11 13:45 ` [PATCH v1 3/5] ACPI: CPPC: Assume no transition latency if no PCCT Pierre Gondois
2022-05-11 14:30 ` Sudeep Holla
2022-05-12 15:04 ` Rafael J. Wysocki
2022-05-11 13:45 ` [PATCH v1 4/5] cpufreq: CPPC: Enable fast_switch Pierre Gondois
2022-05-11 14:41 ` Sudeep Holla
2022-05-12 7:46 ` Viresh Kumar
2022-05-11 13:45 ` [PATCH v1 5/5] cpufreq: CPPC: Enable dvfs_possible_from_any_cpu Pierre Gondois
2022-05-11 14:50 ` Sudeep Holla [this message]
2022-05-12 7:47 ` Viresh Kumar
2022-05-11 14:17 ` [PATCH v1 1/5] ACPI: CPPC: Check _OSC for flexible address space Sudeep Holla
2022-05-12 15:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511145053.mszsbcqsytf6tmfh@bogus \
--to=sudeep.holla@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=Ionela.Voinescu@arm.com \
--cc=devel@acpica.org \
--cc=lenb@kernel.org \
--cc=linuix-kernel@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox