* [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
@ 2022-05-23 14:10 Miaoqian Lin
2022-05-24 7:25 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Miaoqian Lin @ 2022-05-23 14:10 UTC (permalink / raw)
To: Linus Walleij, Sebastian Reichel, Arnd Bergmann, linux-arm-kernel,
linux-pm, linux-kernel
Cc: linmq006
of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/power/reset/arm-versatile-reboot.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/reset/arm-versatile-reboot.c b/drivers/power/reset/arm-versatile-reboot.c
index 08d0a07b58ef..c7624d7611a7 100644
--- a/drivers/power/reset/arm-versatile-reboot.c
+++ b/drivers/power/reset/arm-versatile-reboot.c
@@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void)
versatile_reboot_type = (enum versatile_reboot)reboot_id->data;
syscon_regmap = syscon_node_to_regmap(np);
+ of_node_put(np);
if (IS_ERR(syscon_regmap))
return PTR_ERR(syscon_regmap);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
2022-05-23 14:10 [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe Miaoqian Lin
@ 2022-05-24 7:25 ` Linus Walleij
2022-06-09 19:14 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2022-05-24 7:25 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Sebastian Reichel, Arnd Bergmann, linux-arm-kernel, linux-pm,
linux-kernel
On Mon, May 23, 2022 at 4:10 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node_and_match() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
2022-05-24 7:25 ` Linus Walleij
@ 2022-06-09 19:14 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2022-06-09 19:14 UTC (permalink / raw)
To: Linus Walleij
Cc: Miaoqian Lin, Arnd Bergmann, linux-arm-kernel, linux-pm,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
Hi,
On Tue, May 24, 2022 at 09:25:48AM +0200, Linus Walleij wrote:
> On Mon, May 23, 2022 at 4:10 PM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> > of_find_matching_node_and_match() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when not need anymore.
> > Add missing of_node_put() to avoid refcount leak.
> >
> > Fixes: 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, queued to power-supply's fixes branch.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-09 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-23 14:10 [PATCH] power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe Miaoqian Lin
2022-05-24 7:25 ` Linus Walleij
2022-06-09 19:14 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox