* [PATCH] thermal/drivers/tsens: Use devm_platform_ioremap_resource()
@ 2023-02-17 3:38 ye.xingchen
2023-02-17 6:03 ` Amit Kucheria
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2023-02-17 3:38 UTC (permalink / raw)
To: daniel.lezcano
Cc: agross, andersson, konrad.dybcio, amitk, thara.gopinath, rafael,
rui.zhang, linux-arm-msm, linux-pm, linux-kernel
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Convert platform_get_resource(), devm_ioremap_resource() to a single
call to Use devm_platform_ioremap_resource(), as this is exactly
what this function does.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/thermal/qcom/tsens.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 8020ead2794e..bfe7e4728cf0 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -876,7 +876,6 @@ int __init init_common(struct tsens_priv *priv)
void __iomem *tm_base, *srot_base;
struct device *dev = priv->dev;
u32 ver_minor;
- struct resource *res;
u32 enabled;
int ret, i, j;
struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
@@ -887,8 +886,7 @@ int __init init_common(struct tsens_priv *priv)
if (op->num_resources > 1) {
/* DT with separate SROT and TM address space */
priv->tm_offset = 0;
- res = platform_get_resource(op, IORESOURCE_MEM, 1);
- srot_base = devm_ioremap_resource(dev, res);
+ srot_base = devm_platform_ioremap_resource(op, 1);
if (IS_ERR(srot_base)) {
ret = PTR_ERR(srot_base);
goto err_put_device;
@@ -906,8 +904,7 @@ int __init init_common(struct tsens_priv *priv)
}
if (tsens_version(priv) >= VER_0_1) {
- res = platform_get_resource(op, IORESOURCE_MEM, 0);
- tm_base = devm_ioremap_resource(dev, res);
+ tm_base = devm_platform_ioremap_resource(op, 0);
if (IS_ERR(tm_base)) {
ret = PTR_ERR(tm_base);
goto err_put_device;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal/drivers/tsens: Use devm_platform_ioremap_resource()
2023-02-17 3:38 [PATCH] thermal/drivers/tsens: Use devm_platform_ioremap_resource() ye.xingchen
@ 2023-02-17 6:03 ` Amit Kucheria
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kucheria @ 2023-02-17 6:03 UTC (permalink / raw)
To: ye.xingchen
Cc: daniel.lezcano, agross, andersson, konrad.dybcio, thara.gopinath,
rafael, rui.zhang, linux-arm-msm, linux-pm, linux-kernel
On Fri, Feb 17, 2023 at 9:08 AM <ye.xingchen@zte.com.cn> wrote:
>
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to Use devm_platform_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Acked-by: Amit Kucheria <amitk@kernel.org>
> ---
> drivers/thermal/qcom/tsens.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 8020ead2794e..bfe7e4728cf0 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -876,7 +876,6 @@ int __init init_common(struct tsens_priv *priv)
> void __iomem *tm_base, *srot_base;
> struct device *dev = priv->dev;
> u32 ver_minor;
> - struct resource *res;
> u32 enabled;
> int ret, i, j;
> struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
> @@ -887,8 +886,7 @@ int __init init_common(struct tsens_priv *priv)
> if (op->num_resources > 1) {
> /* DT with separate SROT and TM address space */
> priv->tm_offset = 0;
> - res = platform_get_resource(op, IORESOURCE_MEM, 1);
> - srot_base = devm_ioremap_resource(dev, res);
> + srot_base = devm_platform_ioremap_resource(op, 1);
> if (IS_ERR(srot_base)) {
> ret = PTR_ERR(srot_base);
> goto err_put_device;
> @@ -906,8 +904,7 @@ int __init init_common(struct tsens_priv *priv)
> }
>
> if (tsens_version(priv) >= VER_0_1) {
> - res = platform_get_resource(op, IORESOURCE_MEM, 0);
> - tm_base = devm_ioremap_resource(dev, res);
> + tm_base = devm_platform_ioremap_resource(op, 0);
> if (IS_ERR(tm_base)) {
> ret = PTR_ERR(tm_base);
> goto err_put_device;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-17 6:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-17 3:38 [PATCH] thermal/drivers/tsens: Use devm_platform_ioremap_resource() ye.xingchen
2023-02-17 6:03 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox